Attachment 138113 Details for Bug 105409 – kernel patch to remove the deadzone and palm detection

[patch] kernel patch to remove the deadzone and palm detection

razer_blade.patch (text/plain), 6.05 KB, created by Benjamin Tissoires on 2018-03-14 19:43:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Benjamin Tissoires

Created: 2018-03-14 19:43:11 UTC

Size: 6.05 KB

patch

obsolete

>commit b5b70a90424e2caa66fc6bad8dacfd178eae4a03
>Author: Benjamin Tissoires <benjamin.tissoires@redhat.com>
>Date:   Wed Mar 14 18:02:35 2018 +0100
>
>    HID: multitouch: export a quirk for the button handling of touchpads
>    
>    Instead of using the class name, we better have a specific quirk for it
>    so other classes can make use of it.
>    
>    Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
>
>diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
>index a144d3064829..fc80a9bf3e39 100644
>--- a/drivers/hid/hid-multitouch.c
>+++ b/drivers/hid/hid-multitouch.c
>@@ -74,6 +74,7 @@ MODULE_LICENSE("GPL");
> #define MT_QUIRK_TOUCH_SIZE_SCALING	BIT(15)
> #define MT_QUIRK_STICKY_FINGERS		BIT(16)
> #define MT_QUIRK_ASUS_CUSTOM_UP		BIT(17)
>+#define MT_QUIRK_WIN8_PTP_BUTTONS	BIT(18)
> 
> #define MT_INPUTMODE_TOUCHSCREEN	0x02
> #define MT_INPUTMODE_TOUCHPAD		0x03
>@@ -241,7 +242,8 @@ static struct mt_class mt_classes[] = {
> 			MT_QUIRK_IGNORE_DUPLICATES |
> 			MT_QUIRK_HOVERING |
> 			MT_QUIRK_CONTACT_CNT_ACCURATE |
>-			MT_QUIRK_STICKY_FINGERS },
>+			MT_QUIRK_STICKY_FINGERS |
>+			MT_QUIRK_WIN8_PTP_BUTTONS },
> 	{ .name = MT_CLS_EXPORT_ALL_INPUTS,
> 		.quirks = MT_QUIRK_ALWAYS_VALID |
> 			MT_QUIRK_CONTACT_CNT_ACCURATE,
>@@ -250,7 +252,8 @@ static struct mt_class mt_classes[] = {
> 		.quirks = MT_QUIRK_ALWAYS_VALID |
> 			MT_QUIRK_IGNORE_DUPLICATES |
> 			MT_QUIRK_HOVERING |
>-			MT_QUIRK_CONTACT_CNT_ACCURATE,
>+			MT_QUIRK_CONTACT_CNT_ACCURATE |
>+			MT_QUIRK_WIN8_PTP_BUTTONS,
> 		.export_all_inputs = true },
> 
> 	/*
>@@ -660,8 +663,7 @@ static int mt_touch_input_mapping(struct hid_device *hdev, struct hid_input *hi,
> 		 * MS PTP spec says that external buttons left and right have
> 		 * usages 2 and 3.
> 		 */
>-		if ((cls->name == MT_CLS_WIN_8 ||
>-			cls->name == MT_CLS_WIN_8_DUAL) &&
>+		if ((cls->quirks & MT_QUIRK_WIN8_PTP_BUTTONS) &&
> 		    field->application == HID_DG_TOUCHPAD &&
> 		    (usage->hid & HID_USAGE) > 1)
> 			code--;
>@@ -773,9 +775,7 @@ static void mt_complete_slot(struct mt_device *td, struct input_dev *input)
>  */
> static void mt_sync_frame(struct mt_device *td, struct input_dev *input)
> {
>-	__s32 cls = td->mtclass.name;
>-
>-	if (cls == MT_CLS_WIN_8 || cls == MT_CLS_WIN_8_DUAL)
>+	if (td->mtclass.quirks & MT_QUIRK_WIN8_PTP_BUTTONS)
> 		input_event(input, EV_KEY, BTN_LEFT, td->left_button_state);
> 
> 	input_mt_sync_frame(input);
>@@ -827,7 +827,6 @@ static void mt_process_mt_event(struct hid_device *hid, struct hid_field *field,
> 				bool first_packet)
> {
> 	struct mt_device *td = hid_get_drvdata(hid);
>-	__s32 cls = td->mtclass.name;
> 	__s32 quirks = td->mtclass.quirks;
> 	struct input_dev *input = field->hidinput->input;
> 
>@@ -905,7 +904,7 @@ static void mt_process_mt_event(struct hid_device *hid, struct hid_field *field,
> 			 * non finger/touch events in the first_packet of
> 			 * a (possible) multi-packet frame.
> 			 */
>-			if ((cls == MT_CLS_WIN_8 || cls == MT_CLS_WIN_8_DUAL) &&
>+			if ((quirks & MT_QUIRK_WIN8_PTP_BUTTONS) &&
> 			    !first_packet)
> 				return;
> 
>@@ -916,7 +915,7 @@ static void mt_process_mt_event(struct hid_device *hid, struct hid_field *field,
> 			 * BTN_LEFT if either is pressed, so we or all values
> 			 * together and report the result in mt_sync_frame().
> 			 */
>-			if ((cls == MT_CLS_WIN_8 || cls == MT_CLS_WIN_8_DUAL) &&
>+			if ((quirks & MT_QUIRK_WIN8_PTP_BUTTONS) &&
> 			    usage->type == EV_KEY && usage->code == BTN_LEFT) {
> 				td->left_button_state |= value;
> 				return;
>@@ -940,7 +939,6 @@ static void mt_process_mt_event(struct hid_device *hid, struct hid_field *field,
> static void mt_touch_report(struct hid_device *hid, struct hid_report *report)
> {
> 	struct mt_device *td = hid_get_drvdata(hid);
>-	__s32 cls = td->mtclass.name;
> 	struct hid_field *field;
> 	bool first_packet;
> 	unsigned count;
>@@ -969,7 +967,7 @@ static void mt_touch_report(struct hid_device *hid, struct hid_report *report)
> 		 * of a possible multi-packet frame be checking that the
> 		 * timestamp has changed.
> 		 */
>-		if ((cls == MT_CLS_WIN_8 || cls == MT_CLS_WIN_8_DUAL) &&
>+		if ((td->mtclass.quirks & MT_QUIRK_WIN8_PTP_BUTTONS) &&
> 		    td->num_received == 0 && td->prev_scantime != scantime)
> 			td->num_expected = value;
> 		/* A non 0 contact count always indicates a first packet */
>
>commit 85252f5af86d43d51c8f6d9394303b8dc497fa82
>Author: Benjamin Tissoires <benjamin.tissoires@redhat.com>
>Date:   Wed Mar 14 18:05:08 2018 +0100
>
>    HID: multitouch: remove dead zones of Razer Blade Stealth
>    
>    The Razer Blade Stealth detects palms too aggressively and this creates
>    a dead zone around the touchpad. Users like being able to use their
>    entire touchpad, so we should probably not filter out the "palm" events
>    from the device and report them as regular touches, leaving the palm
>    detection up to the upper stack
>    
>    Link: https://bugs.freedesktop.org/show_bug.cgi?id=105409
>    
>    Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
>
>diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
>index fc80a9bf3e39..520cb5e2c5c3 100644
>--- a/drivers/hid/hid-multitouch.c
>+++ b/drivers/hid/hid-multitouch.c
>@@ -184,6 +184,7 @@ static void mt_post_parse(struct mt_device *td);
> #define MT_CLS_ASUS				0x010b
> #define MT_CLS_VTL				0x0110
> #define MT_CLS_GOOGLE				0x0111
>+#define MT_CLS_RAZER_BLADE_STEALTH		0x0112
> 
> #define MT_DEFAULT_MAXCONTACT	10
> #define MT_MAX_MAXCONTACT	250
>@@ -326,6 +327,13 @@ static struct mt_class mt_classes[] = {
> 			MT_QUIRK_SLOT_IS_CONTACTID |
> 			MT_QUIRK_HOVERING
> 	},
>+	{ .name = MT_CLS_RAZER_BLADE_STEALTH,
>+		.quirks = MT_QUIRK_ALWAYS_VALID |
>+			MT_QUIRK_IGNORE_DUPLICATES |
>+			MT_QUIRK_HOVERING |
>+			MT_QUIRK_CONTACT_CNT_ACCURATE |
>+			MT_QUIRK_WIN8_PTP_BUTTONS,
>+	},
> 	{ }
> };
> 
>@@ -1792,6 +1800,11 @@ static const struct hid_device_id mt_devices[] = {
> 		MT_USB_DEVICE(USB_VENDOR_ID_QUANTA,
> 			USB_DEVICE_ID_QUANTA_OPTICAL_TOUCH_3001) },
> 
>+	/* Razer touchpads */
>+	{ .driver_data = MT_CLS_RAZER_BLADE_STEALTH,
>+		HID_DEVICE(BUS_I2C, HID_GROUP_MULTITOUCH_WIN_8,
>+			USB_VENDOR_ID_SYNAPTICS, 0x8323) },
>+
> 	/* Stantum panels */
> 	{ .driver_data = MT_CLS_CONFIDENCE,
> 		MT_USB_DEVICE(USB_VENDOR_ID_STANTUM_STM,

Actions: View | Splinter Review

Attachments on bug 105409: 137921 | 137922 | 137971 | 138006 | 138007 | 138008 | 138017 | 138049 | 138050 | 138051 | 138052 | 138056 | 138113 | 138118 | 138149

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.