Attachment 138697 Details for Bug 105950 – Patch for si_vgt_param_key endian fix

[patch] Patch for si_vgt_param_key endian fix

0001-radeonsi-correct-si_vgt_param_key-on-big-endian-mach.patch (text/plain), 1.59 KB, created by Bas Vermeulen on 2018-04-09 11:16:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Bas Vermeulen

Created: 2018-04-09 11:16:49 UTC

Size: 1.59 KB

patch

obsolete

>From 92289c778fabe74cd05e7459148344bee069f407 Mon Sep 17 00:00:00 2001
>From: Bas Vermeulen <bas@daedalean.ai>
>Date: Tue, 20 Mar 2018 15:00:56 +0100
>Subject: [PATCH 1/2] radeonsi: correct si_vgt_param_key on big endian machines
>
>Using mesa OpenCL failed on a big endian PowerPC machine because
>si_vgt_param_key is using bitfields and a 32 bit int for an
>index into an array.
>
>Fix si_vgt_param_key to work correctly on both little endian
>and big endian machines.
>
>Signed-off-by: Bas Vermeulen <bas@daedalean.ai>
>---
> src/gallium/drivers/radeonsi/si_pipe.h | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
>diff --git a/src/gallium/drivers/radeonsi/si_pipe.h b/src/gallium/drivers/radeonsi/si_pipe.h
>index 9fb18a84d3..e3e5d5ac91 100644
>--- a/src/gallium/drivers/radeonsi/si_pipe.h
>+++ b/src/gallium/drivers/radeonsi/si_pipe.h
>@@ -464,6 +464,7 @@ struct si_shader_ctx_state {
>  */
> union si_vgt_param_key {
> 	struct {
>+#ifdef PIPE_ARCH_LITTLE_ENDIAN
> 		unsigned prim:4;
> 		unsigned uses_instancing:1;
> 		unsigned multi_instances_smaller_than_primgroup:1;
>@@ -474,6 +475,18 @@ union si_vgt_param_key {
> 		unsigned tess_uses_prim_id:1;
> 		unsigned uses_gs:1;
> 		unsigned _pad:32 - SI_NUM_VGT_PARAM_KEY_BITS;
>+#else /* PIPE_ARCH_BIG_ENDIAN */
>+		unsigned _pad:32 - SI_NUM_VGT_PARAM_KEY_BITS;
>+		unsigned uses_gs:1;
>+		unsigned tess_uses_prim_id:1;
>+		unsigned uses_tess:1;
>+		unsigned line_stipple_enabled:1;
>+		unsigned count_from_stream_output:1;
>+		unsigned primitive_restart:1;
>+		unsigned multi_instances_smaller_than_primgroup:1;
>+		unsigned uses_instancing:1;
>+		unsigned prim:4;
>+#endif
> 	} u;
> 	uint32_t index;
> };
>-- 
>2.14.1
>

Actions: View | Splinter Review

Attachments on bug 105950: 138697 | 138698

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.