Attachment 139140 Details for Bug 106232 – patch to fix bogus random numbers

[patch] patch to fix bogus random numbers

lp_test_rand.diff (text/plain), 1.50 KB, created by Roland Scheidegger on 2018-04-26 16:07:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Roland Scheidegger

Created: 2018-04-26 16:07:58 UTC

Size: 1.50 KB

patch

obsolete

>diff --git a/src/gallium/drivers/llvmpipe/lp_test_main.c b/src/gallium/drivers/llvmpipe/lp_test_main.c
>index 518ca27..5ec0dd3 100644
>--- a/src/gallium/drivers/llvmpipe/lp_test_main.c
>+++ b/src/gallium/drivers/llvmpipe/lp_test_main.c
>@@ -147,6 +147,7 @@ write_elem(struct lp_type type, void *dst, unsigned index, double value)
>       if(type.sign) {
>          long long lvalue = (long long)value;
>          lvalue = MIN2(lvalue, ((long long)1 << (type.width - 1)) - 1);
>+         lvalue = MAX2(lvalue, -((long long)1 << (type.width - 1)));
>          switch(type.width) {
>          case 8:
>             *((int8_t *)dst + index) = (int8_t)lvalue;
>@@ -200,16 +201,24 @@ random_elem(struct lp_type type, void *dst, unsigned index)
>       }
>       else {
>          unsigned long long mask;
>-	 if (type.fixed)
>+         if (type.fixed)
>             mask = ((unsigned long long)1 << (type.width / 2)) - 1;
>          else if (type.sign)
>             mask = ((unsigned long long)1 << (type.width - 1)) - 1;
>          else
>             mask = ((unsigned long long)1 << type.width) - 1;
>          value += (double)(mask & rand());
>+         if (!type.fixed && !type.sign && type.width == 32) {
>+            /*
>+             * rand only returns half the possible range
>+             * XXX 64bit values...
>+             */
>+            if(rand() & 1)
>+               value += (double)0x80000000;
>+         }
>       }
>    }
>-   if(!type.sign)
>+   if(type.sign)
>       if(rand() & 1)
>          value = -value;
>    write_elem(type, dst, index, value);

Actions: View | Splinter Review

Attachments on bug 106232: 139140

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.