Attachment 139286 Details for Bug 106236 – service-client: Fix warning with GLib >= 2.56

[patch] service-client: Fix warning with GLib >= 2.56

service-client-Fix-warning-with-GLib--256.patch (text/plain), 1.47 KB, created by Zeeshan Ali on 2018-05-02 21:07:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Zeeshan Ali

Created: 2018-05-02 21:07:35 UTC

Size: 1.47 KB

patch

obsolete

>From a917f905d1faae5bc5ab4f74b71a399d7f6284b5 Mon Sep 17 00:00:00 2001
>From: Bastien Nocera <hadess@hadess.net>
>Date: Wed, 2 May 2018 11:18:34 +0200
>Subject: [PATCH] service-client: Fix warning with GLib >= 2.56
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>geoclue/src/gclue-service-client.c: In function âgclue_service_client_handle_startâ:
>geoclue/src/gclue-service-client.c:574:22: warning: assignment to âGClueServiceClient *â {aka âstruct _GClueServiceClient *â} from incompatible pointer type âGClueDBusClient *â {aka âstruct _GClueDBusClient *â} [-Wincompatible-pointer-types]
>         data->client = g_object_ref (client);
>                      ^
>
>See https://bugzilla.gnome.org/show_bug.cgi?id=790697 for the
>gobject change that triggers this warning.
>
>https://bugs.freedesktop.org/show_bug.cgi?id=106236
>---
> src/gclue-service-client.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/src/gclue-service-client.c b/src/gclue-service-client.c
>index d115459..13dd19d 100644
>--- a/src/gclue-service-client.c
>+++ b/src/gclue-service-client.c
>@@ -496,7 +496,7 @@ gclue_service_client_handle_start (GClueDBusClient       *client,
>         }
> 
>         data = g_slice_new (StartData);
>-        data->client = g_object_ref (client);
>+        data->client = g_object_ref (GCLUE_SERVICE_CLIENT (client));
>         data->invocation =  g_object_ref (invocation);
>         data->desktop_id =  g_strdup (desktop_id);
> 
>-- 
>2.14.3

Actions: View | Splinter Review

Attachments on bug 106236: 139106 | 139125 | 139127 | 139138 | 139139 | 139158 | 139159 | 139164 | 139165 | 139166 | 139264 | 139265 | 139266 | 139275 | 139279 | 139285 | 139286 | 139287 | 139301

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.