Attachment 139293 Details for Bug 101972 – Fix useradd failures caused by invalid read

[patch] Fix useradd failures caused by invalid read

Fix-useradd-failures-caused-by-invalid-read.patch (text/plain), 2.53 KB, created by Ondrej Holy on 2018-05-03 07:42:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ondrej Holy

Created: 2018-05-03 07:42:56 UTC

Size: 2.53 KB

patch

obsolete

>From 57330a647b12789df831d9805283addccc56ad15 Mon Sep 17 00:00:00 2001
>From: Ondrej Holy <oholy@redhat.com>
>Date: Thu, 3 May 2018 09:33:17 +0200
>Subject: [PATCH] Fix useradd failures caused by invalid read
>
>Commit 93e2a85 added support for extra admin groups, but causes useradd
>failures, when adding admin accounts. It is because admin_groups are
>released before they are actually used, which causes that garbage is
>used instead of the group and useradd fails consequently with invalid
>group name. Do not release the memory before it is used and also fix
>one corresponding memory leak.
>
>https://bugs.freedesktop.org/show_bug.cgi?id=101972
>---
> src/daemon.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
>diff --git a/src/daemon.c b/src/daemon.c
>index cf82842..2ffd4b3 100644
>--- a/src/daemon.c
>+++ b/src/daemon.c
>@@ -1082,6 +1082,7 @@ daemon_create_user_authorized_cb (Daemon                *daemon,
>         User *user;
>         GError *error;
>         const gchar *argv[9];
>+        char *admin_groups = NULL;
> 
>         if (getpwnam (cd->user_name) != NULL) {
>                 throw_error (context, ERROR_USER_EXISTS, "A user with name '%s' already exists", cd->user_name);
>@@ -1096,20 +1097,17 @@ daemon_create_user_authorized_cb (Daemon                *daemon,
>         argv[2] = "-c";
>         argv[3] = cd->real_name;
>         if (cd->account_type == ACCOUNT_TYPE_ADMINISTRATOR) {
>-                char *admin_groups;
>-
>-                admin_groups = g_strdup (ADMIN_GROUP);
>                 if (EXTRA_ADMIN_GROUPS != NULL && EXTRA_ADMIN_GROUPS[0] != '\0')
>-                        admin_groups = g_strconcat (admin_groups, ",",
>+                        admin_groups = g_strconcat (ADMIN_GROUP, ",",
>                                                     EXTRA_ADMIN_GROUPS, NULL);
>+                else
>+                        admin_groups = g_strdup (ADMIN_GROUP);
> 
>                 argv[4] = "-G";
>                 argv[5] = admin_groups;
>                 argv[6] = "--";
>                 argv[7] = cd->user_name;
>                 argv[8] = NULL;
>-
>-                g_free (admin_groups);
>         }
>         else if (cd->account_type == ACCOUNT_TYPE_STANDARD) {
>                 argv[4] = "--";
>@@ -1128,6 +1126,8 @@ daemon_create_user_authorized_cb (Daemon                *daemon,
>                 return;
>         }
> 
>+        g_free (admin_groups);
>+
>         user = daemon_local_find_user_by_name (daemon, cd->user_name);
>         user_update_local_account_property (user, TRUE);
>         user_update_system_account_property (user, FALSE);
>-- 
>2.17.0

Actions: View | Splinter Review

Attachments on bug 101972: 133135 | 139293

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.