Attachment 139691 Details for Bug 100436 – 0001-HID-rmi-use-HID_QUIRK_NO_INPUT_SYNC.patch

[patch] 0001-HID-rmi-use-HID_QUIRK_NO_INPUT_SYNC.patch

0001-HID-rmi-use-HID_QUIRK_NO_INPUT_SYNC.patch (text/plain), 1.96 KB, created by Benjamin Tissoires on 2018-05-23 09:13:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Benjamin Tissoires

Created: 2018-05-23 09:13:28 UTC

Size: 1.96 KB

patch

obsolete

>From 91043966d92d013b9c5668d545517c78c435850d Mon Sep 17 00:00:00 2001
>From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
>Date: Wed, 23 May 2018 11:11:01 +0200
>Subject: [PATCH] HID: rmi: use HID_QUIRK_NO_INPUT_SYNC
>
>When we receive a RMI4 report, we should not unconditionally send an
>input_sync event. Instead, we should let the rmi4 transport layer do it
>for us.
>
>This fixes a situation where we might receive X in a report and the rest
>in a subsequent one. And this messes up user space.
>
>Link: https://bugs.freedesktop.org/show_bug.cgi?id=100436
>
>Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
>---
> drivers/hid/hid-rmi.c | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
>diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid-rmi.c
>index 9c9362149641..9e33165250a3 100644
>--- a/drivers/hid/hid-rmi.c
>+++ b/drivers/hid/hid-rmi.c
>@@ -413,6 +413,24 @@ static int rmi_event(struct hid_device *hdev, struct hid_field *field,
> 	return 0;
> }
> 
>+static void rmi_report(struct hid_device *hid, struct hid_report *report)
>+{
>+	struct hid_field *field = report->field[0];
>+
>+	if (!(hid->claimed & HID_CLAIMED_INPUT))
>+		return;
>+
>+	switch (report->id) {
>+	case RMI_READ_DATA_REPORT_ID:
>+		/* fall-through */
>+	case RMI_ATTN_REPORT_ID:
>+		return;
>+	}
>+
>+	if (field && field->hidinput && field->hidinput->input)
>+		input_sync(field->hidinput->input);
>+}
>+
> #ifdef CONFIG_PM
> static int rmi_suspend(struct hid_device *hdev, pm_message_t message)
> {
>@@ -637,6 +655,7 @@ static int rmi_probe(struct hid_device *hdev, const struct hid_device_id *id)
> 	hid_set_drvdata(hdev, data);
> 
> 	hdev->quirks |= HID_QUIRK_NO_INIT_REPORTS;
>+	hdev->quirks |= HID_QUIRK_NO_INPUT_SYNC;
> 
> 	ret = hid_parse(hdev);
> 	if (ret) {
>@@ -744,6 +763,7 @@ static struct hid_driver rmi_driver = {
> 	.remove			= rmi_remove,
> 	.event			= rmi_event,
> 	.raw_event		= rmi_raw_event,
>+	.report			= rmi_report,
> 	.input_mapping		= rmi_input_mapping,
> 	.input_configured	= rmi_input_configured,
> #ifdef CONFIG_PM
>-- 
>2.14.3
>

Actions: View | Splinter Review

Attachments on bug 100436: 130512 | 130513 | 130522 | 130523 | 130524 | 130525 | 130629 | 139543 | 139544 | 139691 | 140112

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.