Attachment 139814 Details for Bug 106687 – Possible fix

[patch] Possible fix

0001-radv-Use-correct-color-format-for-fast-clears.patch (text/plain), 1.27 KB, created by Philip Rebohle on 2018-05-28 12:59:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Philip Rebohle

Created: 2018-05-28 12:59:34 UTC

Size: 1.27 KB

patch

obsolete

>From 268f78e4716de6c84b2ade468d878df484c219e2 Mon Sep 17 00:00:00 2001
>From: Philip Rebohle <philip.rebohle@tu-dortmund.de>
>Date: Mon, 28 May 2018 14:10:41 +0200
>Subject: [PATCH] radv: Use correct color format for fast clears
>
>Using the image format is incorrect when the view has a different
>format than the image. Instead, the view format needs to be used.
>---
> src/amd/vulkan/radv_meta_clear.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/src/amd/vulkan/radv_meta_clear.c b/src/amd/vulkan/radv_meta_clear.c
>index 858e3368b6..fae441ceb6 100644
>--- a/src/amd/vulkan/radv_meta_clear.c
>+++ b/src/amd/vulkan/radv_meta_clear.c
>@@ -1035,7 +1035,7 @@ emit_fast_color_clear(struct radv_cmd_buffer *cmd_buffer,
> 		goto fail;
> 
> 	/* DCC */
>-	ret = radv_format_pack_clear_color(iview->image->vk_format,
>+	ret = radv_format_pack_clear_color(iview->vk_format,
> 					   clear_color, &clear_value);
> 	if (ret == false)
> 		goto fail;
>@@ -1056,7 +1056,7 @@ emit_fast_color_clear(struct radv_cmd_buffer *cmd_buffer,
> 		bool can_avoid_fast_clear_elim;
> 		bool need_decompress_pass = false;
> 
>-		vi_get_fast_clear_parameters(iview->image->vk_format,
>+		vi_get_fast_clear_parameters(iview->vk_format,
> 					     &clear_value, &reset_value,
> 					     &can_avoid_fast_clear_elim);
> 
>-- 
>2.17.0
>

Actions: View | Splinter Review

Attachments on bug 106687: 139814

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.