Attachment 140013 Details for Bug 106812 – 4/5] server-oom test: Don't assume localhost is resolvable

[patch] 4/5] server-oom test: Don't assume localhost is resolvable

0004-server-oom-test-Don-t-assume-localhost-is-resolvable.patch (text/plain), 1.58 KB, created by Simon McVittie on 2018-06-04 15:36:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2018-06-04 15:36:59 UTC

Size: 1.58 KB

patch

obsolete

>From 14fe4690f4c714c7fefff623f45f7206ecfadc64 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <smcv@collabora.com>
>Date: Mon, 4 Jun 2018 16:27:49 +0100
>Subject: [PATCH 4/5] server-oom test: Don't assume localhost is resolvable
>
>Pathological autobuilder environments might not list localhost in
>/etc/hosts.
>
>Signed-off-by: Simon McVittie <smcv@collabora.com>
>---
> test/internals/server-oom.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/test/internals/server-oom.c b/test/internals/server-oom.c
>index f9f0a870..839adb84 100644
>--- a/test/internals/server-oom.c
>+++ b/test/internals/server-oom.c
>@@ -121,10 +121,10 @@ main (int argc,
>   test_init (&argc, &argv);
> 
>   test_cases_to_free = g_queue_new ();
>-  add_oom_test ("/server/new-tcp", test_new_server, "tcp:host=localhost,bind=localhost");
>-  add_oom_test ("/server/new-nonce-tcp", test_new_server, "nonce-tcp:host=localhost,bind=localhost");
>-  add_oom_test ("/server/new-tcp-star", test_new_server, "tcp:host=localhost,bind=*");
>-  add_oom_test ("/server/new-tcp-v4", test_new_server, "tcp:host=localhost,bind=localhost,family=ipv4");
>+  add_oom_test ("/server/new-tcp", test_new_server, "tcp:host=127.0.0.1,bind=127.0.0.1");
>+  add_oom_test ("/server/new-nonce-tcp", test_new_server, "nonce-tcp:host=127.0.0.1,bind=127.0.0.1");
>+  add_oom_test ("/server/new-tcp-star", test_new_server, "tcp:host=127.0.0.1,bind=*");
>+  add_oom_test ("/server/new-tcp-v4", test_new_server, "tcp:host=127.0.0.1,bind=127.0.0.1,family=ipv4");
> #ifdef DBUS_UNIX
>   add_oom_test ("/server/unix", test_new_server, "unix:tmpdir=/tmp");
> #endif
>-- 
>2.17.1
>

Actions: View | Splinter Review

Attachments on bug 106812: 140011 | 140012 | 140013 | 140014

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.