Attachment 140142 Details for Bug 106904 – A proposed patch.

[patch] A proposed patch.

0001-daemon-don-t-abort-loading-users-even-if-missing-sha.patch (text/plain), 1.15 KB, created by Felix Zhang on 2018-06-13 05:45:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Felix Zhang

Created: 2018-06-13 05:45:15 UTC

Size: 1.15 KB

patch

obsolete

>From c9503bcb40c21da08b7938279117d68ec37ac1f1 Mon Sep 17 00:00:00 2001
>From: Felix Zhang <fezhang@suse.com>
>Date: Wed, 13 Jun 2018 11:05:52 +0800
>Subject: [PATCH] daemon: don't abort loading users even if missing shadow
> entries
>
>Some system accounts, e.g. sshd have no entries in /etc/shadow
>because they are created prior to /etc/shadow and have no passwords.
>
>Right now load_entries aborts iterating through /etc/passwd entries
>if it fails to find the corresponding /etc/shadow entry, ignoring
>all the users behind it, making those users missing from the gdm
>login screen user list.
>
>https://bugs.freedesktop.org/show_bug.cgi?id=106904
>---
> src/daemon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/src/daemon.c b/src/daemon.c
>index e711a46..2851ed6 100644
>--- a/src/daemon.c
>+++ b/src/daemon.c
>@@ -235,8 +235,8 @@ entry_generator_fgetpwent (Daemon       *daemon,
> 
>                         if (shadow_entry_buffers != NULL) {
>                             *spent = &shadow_entry_buffers->spbuf;
>-                            return pwent;
>                         }
>+                        return pwent;
>                 }
>         }
> 
>-- 
>2.13.7
>

Actions: View | Splinter Review

Attachments on bug 106904: 140142

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.