Attachment 140295 Details for Bug 107012 – Fix crashes

[patch] Fix crashes

0001-radeonsi-Use-signed-char-for-color_interp_vgpr_index.patch (text/plain), 1.17 KB, created by Timothy Pearson on 2018-06-24 00:41:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Timothy Pearson

Created: 2018-06-24 00:41:57 UTC

Size: 1.17 KB

patch

obsolete

>From 2a68e00145f1eb68f25e7dcdf76a9d1f2184544a Mon Sep 17 00:00:00 2001
>From: Timothy Pearson <tpearson@raptorengineering.com>
>Date: Sat, 23 Jun 2018 19:39:41 -0500
>Subject: [PATCH] radeonsi: Use signed char for color_interp_vgpr_index
>
>color_interp_vgpr_index was declared as a generic char value.
>Because signed values are used in this variable, the result
>was not safe across architectures and crashed on ppc64[el]
>and arm.
>
>Declare color_interp_vgpr_index as a signed type.
>
>Signed-off-by: Timothy Pearson <tpearson@raptorengineering.com>
>---
> src/gallium/drivers/radeonsi/si_shader.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/src/gallium/drivers/radeonsi/si_shader.h b/src/gallium/drivers/radeonsi/si_shader.h
>index 9e8d573625..791ed27324 100644
>--- a/src/gallium/drivers/radeonsi/si_shader.h
>+++ b/src/gallium/drivers/radeonsi/si_shader.h
>@@ -507,7 +507,7 @@ union si_shader_part_key {
> 		unsigned	ancillary_vgpr_index:5;
> 		unsigned	wqm:1;
> 		char		color_attr_index[2];
>-		char		color_interp_vgpr_index[2]; /* -1 == constant */
>+		signed char	color_interp_vgpr_index[2]; /* -1 == constant */
> 	} ps_prolog;
> 	struct {
> 		struct si_ps_epilog_bits states;
>-- 
>2.17.1

Actions: View | Splinter Review

Attachments on bug 107012: 140294 | 140295

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.