Attachment 140348 Details for Bug 107047 – [PATCH 1/3] ply-renderer: Fix activate handling

[patch] [PATCH 1/3] ply-renderer: Fix activate handling

0001-ply-renderer-Fix-activate-handling.patch (text/plain), 1.05 KB, created by Hans de Goede on 2018-06-26 18:53:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Hans de Goede

Created: 2018-06-26 18:53:47 UTC

Size: 1.05 KB

patch

obsolete

>From 4fd97f4050f0746ca28e8cb741e8dce9def51df3 Mon Sep 17 00:00:00 2001
>From: Hans de Goede <hdegoede@redhat.com>
>Date: Mon, 25 Jun 2018 22:02:07 +0200
>Subject: [PATCH 1/3] ply-renderer: Fix activate handling
>
>Fix ply_renderer_activate() only working once, because renderer->is_active
>was not cleared on a deactivate, breaking things after a deactivate() +
>activate() cycle.
>
>Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>---
> src/libply-splash-core/ply-renderer.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/src/libply-splash-core/ply-renderer.c b/src/libply-splash-core/ply-renderer.c
>index b9059ef..ecf7082 100644
>--- a/src/libply-splash-core/ply-renderer.c
>+++ b/src/libply-splash-core/ply-renderer.c
>@@ -314,7 +314,8 @@ ply_renderer_deactivate (ply_renderer_t *renderer)
> {
>         assert (renderer->plugin_interface != NULL);
> 
>-        return renderer->plugin_interface->deactivate (renderer->backend);
>+        renderer->plugin_interface->deactivate (renderer->backend);
>+        renderer->is_active = false;
> }
> 
> bool
>-- 
>2.17.1
>

Actions: View | Splinter Review

Attachments on bug 107047: 140348 | 140349 | 140350 | 140422 | 140444

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.