Attachment 140423 Details for Bug 107086 – [PATCH 1/2] configure: Pass -Wno-cast-function-type if available

[patch] [PATCH 1/2] configure: Pass -Wno-cast-function-type if available

0001-configure-Pass-Wno-cast-function-type-if-available.patch (text/plain), 1.61 KB, created by Hans de Goede on 2018-07-02 11:10:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Hans de Goede

Created: 2018-07-02 11:10:08 UTC

Size: 1.61 KB

patch

obsolete

>From 4b48ada92bb8ed30e369e37ff3a2108fedaf2a4c Mon Sep 17 00:00:00 2001
>From: Hans de Goede <hdegoede@redhat.com>
>Date: Mon, 2 Jul 2018 10:01:05 +0200
>Subject: [PATCH 1/2] configure: Pass -Wno-cast-function-type if available
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>plymouth uses function type casts for callbacks in quite a few places, fixing
>these needlessly complicates the code, so lets pass -Wno-cast-function-type.
>
>This fixes 218 warnings like this one:
>
>ply-command-parser.c: In function âply_command_parser_stop_parsing_argumentsâ:
>ply-command-parser.c:680:48: warning: cast between incompatible function types from âvoid (*)(ply_command_parser_t *)â {aka âvoid (*)(struct _ply_command_parser *)â} to âvoid (*)(void *, int,  ply_event_loop_t *)â {aka âvoid (*)(void *, int,  struct _ply_event_loop *)â} [-Wcast-function-type]
>                                                (ply_event_loop_exit_handler_t)
>
>Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>---
> configure.ac | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/configure.ac b/configure.ac
>index b51a700..0382773 100644
>--- a/configure.ac
>+++ b/configure.ac
>@@ -227,6 +227,7 @@ if test "$GCC" = "yes" -a "$set_more_warnings" != "no"; then
>    -Wwrite-strings -Wnested-externs -Wpointer-arith \
>    -Wswitch-enum -Wstrict-aliasing=2 -Winit-self -Wunsafe-loop-optimizations \
>    -Wno-missing-field-initializers -Wno-unused-parameter -Wno-unused-result \
>+   -Wno-cast-function-type \
>    -Wcast-align -Wsign-compare -Wp,-D_FORTIFY_SOURCE=2"
> elif test "$GCC" = "yes"; then
>   AC_MSG_RESULT(no)
>-- 
>2.17.1
>

Actions: View | Splinter Review

Attachments on bug 107086: 140423 | 140424

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.