Attachment 140464 Details for Bug 106959 – Adding YCbCr4:2:0 pixel encoding support for HDMI connectors

[patch] Adding YCbCr4:2:0 pixel encoding support for HDMI connectors

0001-drm-amdgpu-add-ycbcr420-pixel-encoding-for-hdmi.patch (text/plain), 1.96 KB, created by Mikita Lipski on 2018-07-04 13:33:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mikita Lipski

Created: 2018-07-04 13:33:23 UTC

Size: 1.96 KB

patch

obsolete

>From a24b5c5b6877d031ec42ff3d65095bac67372f2a Mon Sep 17 00:00:00 2001
>From: Mikita Lipski <mikita.lipski@amd.com>
>Date: Wed, 4 Jul 2018 09:27:02 -0400
>Subject: [PATCH] drm/amdgpu: add ycbcr420 pixel encoding for hdmi
>
>[why]
>HDMI EDID's VSDB contains spectial timings for specifically
>YCbCr 4:2:0 colour space. In those cases we need to verify
>if the mode provided is one of the special ones has to use
>YCbCr 4:2:0 pixel encoding for display info.
>[how]
>Add an if statement using DRM helper function to check
>if its specific ycbcr420 mode and assign it to pixel encoding
>
>Signed-off-by: Mikita Lipski <mikita.lipski@amd.com>
>---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>index 01d14d8..ed09e36 100644
>--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>@@ -2226,7 +2226,7 @@ fill_stream_properties_from_drm_display_mode(struct dc_stream_state *stream,
> 					     const struct drm_connector *connector)
> {
> 	struct dc_crtc_timing *timing_out = &stream->timing;
>-
>+	const struct drm_display_info *info = &connector->display_info;
> 	memset(timing_out, 0, sizeof(struct dc_crtc_timing));
> 
> 	timing_out->h_border_left = 0;
>@@ -2234,8 +2234,10 @@ fill_stream_properties_from_drm_display_mode(struct dc_stream_state *stream,
> 	timing_out->v_border_top = 0;
> 	timing_out->v_border_bottom = 0;
> 	/* TODO: un-hardcode */
>-
>-	if ((connector->display_info.color_formats & DRM_COLOR_FORMAT_YCRCB444)
>+	if (drm_mode_is_420_only(info, mode_in)
>+			&& stream->sink->sink_signal == SIGNAL_TYPE_HDMI_TYPE_A)
>+		timing_out->pixel_encoding = PIXEL_ENCODING_YCBCR420;
>+	else if ((connector->display_info.color_formats & DRM_COLOR_FORMAT_YCRCB444)
> 			&& stream->sink->sink_signal == SIGNAL_TYPE_HDMI_TYPE_A)
> 		timing_out->pixel_encoding = PIXEL_ENCODING_YCBCR444;
> 	else
>-- 
>2.7.4
>

Actions: View | Splinter Review

Attachments on bug 106959: 140217 | 140218 | 140219 | 140220 | 140247 | 140248 | 140256 | 140266 | 140267 | 140449 | 140450 | 140464

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.