Attachment 140594 Details for Bug 107082 – [PATCH] drm/amd/display: Convert 10kHz clks from PPLib into kHz for Vega

[patch] [PATCH] drm/amd/display: Convert 10kHz clks from PPLib into kHz for Vega

0001-drm-amd-display-Convert-10kHz-clks-from-PPLib-into-k.patch (text/plain), 1.76 KB, created by Harry Wentland on 2018-07-12 13:58:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Harry Wentland

Created: 2018-07-12 13:58:05 UTC

Size: 1.76 KB

patch

obsolete

>From e2e9d9a32cd544dbfc3ceacf7be3afc5a40dd9b5 Mon Sep 17 00:00:00 2001
>From: Harry Wentland <harry.wentland@amd.com>
>Date: Thu, 31 May 2018 14:44:18 -0400
>Subject: [PATCH] drm/amd/display: Convert 10kHz clks from PPLib into kHz for
> Vega
>
>The driver is expecting clock frequency in kHz, while SMU returns
>the values in 10kHz, which causes the bandwidth validation to fail
>
>4.18 has the faulty clock assignment in pp_to_dc_clock_levels_with_latency
>only, which is only used by Vega. Make sure we multiply these values
>by 10 here, as we do for other ASICs as powerplay assigned them
>wrong. 4.19 has the proper fix in powerplay.
>
>Signed-off-by: Mikita Lipski <mikita.lipski@amd.com>
>Signed-off-by: Harry Wentland <harry.wentland@amd.com>
>---
>
>Alex, please pull this into drm-fixes-4.18.
>
>Harry
>
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_services.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_services.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_services.c
>index 5a3346124a01..5a2e952c5bea 100644
>--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_services.c
>+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_services.c
>@@ -255,8 +255,9 @@ static void pp_to_dc_clock_levels_with_latency(
> 			DC_DECODE_PP_CLOCK_TYPE(dc_clk_type));
> 
> 	for (i = 0; i < clk_level_info->num_levels; i++) {
>-		DRM_DEBUG("DM_PPLIB:\t %d\n", pp_clks->data[i].clocks_in_khz);
>-		clk_level_info->data[i].clocks_in_khz = pp_clks->data[i].clocks_in_khz;
>+		DRM_DEBUG("DM_PPLIB:\t %d in 10kHz\n", pp_clks->data[i].clocks_in_khz);
>+		/* translate 10kHz to kHz */
>+		clk_level_info->data[i].clocks_in_khz = pp_clks->data[i].clocks_in_khz * 10;
> 		clk_level_info->data[i].latency_in_us = pp_clks->data[i].latency_in_us;
> 	}
> }
>-- 
>2.17.1
>

Actions: View | Splinter Review

Attachments on bug 107082: 140594

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.