Attachment 140625 Details for Bug 107066 – Don't share clk source between DP and other connectors

[patch] Don't share clk source between DP and other connectors

0001-drm-amdgpu-display-Don-t-share-clk-source-between-DP.patch (text/plain), 1.45 KB, created by Mikita Lipski on 2018-07-13 15:23:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mikita Lipski

Created: 2018-07-13 15:23:25 UTC

Size: 1.45 KB

patch

obsolete

>From 835ae6348abd9d325902676f9c066f819994ab38 Mon Sep 17 00:00:00 2001
>From: Mikita Lipski <mikita.lipski@amd.com>
>Date: Thu, 12 Jul 2018 16:44:05 -0400
>Subject: [PATCH] drm/amdgpu/display: Don't share clk source between DP and
> HDMI
>
>[why]
>Prevent clock source sharing between HDMI and DP connectors.
>DP shouldn't be sharing its ref clock with phy clock,
>which caused an issue of older ASICS booting up with multiple
>diplays plugged in.
>
>[how]
>Add an extra check that would prevent HDMI and DP sharing clk.
>
>Change-Id: I7c4cf339c7996d91c60d23850ae917602fc0b73b
>Signed-off-by: Mikita Lipski <mikita.lipski@amd.com>
>---
> drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c b/drivers/gpu/drm/amd/display/dc/core/dc_resource.c
>index f92c373..b041e48 100644
>--- a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c
>+++ b/drivers/gpu/drm/amd/display/dc/core/dc_resource.c
>@@ -348,7 +348,10 @@ static bool is_sharable_clk_src(
> 	if (pipe_with_clk_src->stream->signal == SIGNAL_TYPE_VIRTUAL)
> 		return false;
> 
>-	if (dc_is_dp_signal(pipe_with_clk_src->stream->signal))
>+	if ((dc_is_dp_signal(pipe_with_clk_src->stream->signal) &&
>+			!dc_is_dp_signal(pipe->stream->signal)) ||
>+			(dc_is_dp_signal(pipe->stream->signal) &&
>+			!dc_is_dp_signal(pipe_with_clk_src->stream->signal)))
> 		return false;
> 
> 	if (dc_is_hdmi_signal(pipe_with_clk_src->stream->signal)
>-- 
>2.7.4
>

Actions: View | Splinter Review

Attachments on bug 107066: 140384 | 140625 | 140626 | 140627 | 140629

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.