Attachment 140715 Details for Bug 107065 – 0001-drm-amdgpu-Fix-S3-resume-failre.patch

[patch] 0001-drm-amdgpu-Fix-S3-resume-failre.patch

0001-drm-amdgpu-Fix-S3-resume-failre.patch (text/plain), 1.68 KB, created by Andrey Grodzovsky on 2018-07-19 16:42:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andrey Grodzovsky

Created: 2018-07-19 16:42:26 UTC

Size: 1.68 KB

patch

obsolete

>From 1eb58ee20718ca11da127ebf8f6ac98b0a12c7e3 Mon Sep 17 00:00:00 2001
>From: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
>Date: Thu, 19 Jul 2018 11:09:14 -0400
>Subject: drm/amdgpu: Fix S3 resume failre.
>
>Problem:
>FB is still not unpinned during the first run of amdgpu_bo_evict_vram
>and so it's left for the second run, but during second run the SDMA for
>moving buffer around already disabled and you have to do
>it with CPU, but FB is not in visible VRAM and hence the eviction failure
>leading later to resume failure.
>
>Fix:
>When DAL in use get a pointer to FB from crtc->primary->state rather
>then from crtc->primary which is not set for DAL since it supports
>atomic KMS.
>
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107065
>Fixes e00fb85 drm: Stop updating plane->crtc/fb/old_fb on atomic drivers
>Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
>---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>index 709e4a3..dd9ebf7 100644
>--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>@@ -2642,7 +2642,8 @@ int amdgpu_device_suspend(struct drm_device *dev, bool suspend, bool fbcon)
> 	/* unpin the front buffers and cursors */
> 	list_for_each_entry(crtc, &dev->mode_config.crtc_list, head) {
> 		struct amdgpu_crtc *amdgpu_crtc = to_amdgpu_crtc(crtc);
>-		struct drm_framebuffer *fb = crtc->primary->fb;
>+		 struct drm_framebuffer *fb = amdgpu_device_has_dc_support(adev) ?
>+				 crtc->primary->state->fb : crtc->primary->fb;
> 		struct amdgpu_bo *robj;
> 
> 		if (amdgpu_crtc->cursor_bo) {
>-- 
>2.7.4
>

Actions: View | Splinter Review

Attachments on bug 107065: 140383 | 140418 | 140634 | 140715 | 140721

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.