Attachment 140749 Details for Bug 107317 – Patch to fix bug

[patch] Patch to fix bug

0002-Fixed-HtmlFont-HtmlFilter-to-convert-tabs-to-spaces.patch (text/plain), 1.31 KB, created by ulatekh on 2018-07-21 03:46:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: ulatekh

Created: 2018-07-21 03:46:43 UTC

Size: 1.31 KB

patch

obsolete

>From 1657c5261432ba7b5512476e1073dbe93506cc85 Mon Sep 17 00:00:00 2001
>From: ulatekh <ulatekh@yahoo.com>
>Date: Sun, 15 Jul 2018 09:06:33 -0700
>Subject: [PATCH 2/3] Fixed HtmlFont::HtmlFilter() to convert tabs to spaces.
>
>This is preferable to removing the whitespace completely.
>---
> utils/HtmlFonts.cc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/utils/HtmlFonts.cc b/utils/HtmlFonts.cc
>index 97478c3c..4c65d5f5 100644
>--- a/utils/HtmlFonts.cc
>+++ b/utils/HtmlFonts.cc
>@@ -256,7 +256,7 @@ GooString* HtmlFont::HtmlFilter(const Unicode* u, int uLen) {
>   for (int i = 0; i < uLen; ++i) {
>     // skip control characters.  W3C disallows them and they cause a warning
>     // with PHP.
>-    if (u[i] <= 31)
>+    if (u[i] <= 31 && u[i] != '\t')
>       continue;
> 
>     switch (u[i])
>@@ -265,7 +265,7 @@ GooString* HtmlFont::HtmlFilter(const Unicode* u, int uLen) {
> 	case '&': tmp->append("&amp;");  break;
> 	case '<': tmp->append("&lt;");  break;
> 	case '>': tmp->append("&gt;");  break;
>-	case ' ': tmp->append( !xml && ( i+1 >= uLen || !tmp->getLength() || tmp->getChar( tmp->getLength()-1 ) == ' ' ) ? "&#160;" : " " );
>+	case '\t': case ' ': tmp->append( !xml && ( i+1 >= uLen || !tmp->getLength() || tmp->getChar( tmp->getLength()-1 ) == ' ' ) ? "&#160;" : " " );
> 	          break;
> 	default:  
> 	  {
>-- 
>2.14.4
>

Actions: View | Splinter Review

Attachments on bug 107317: 140749

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.