Attachment 140789 Details for Bug 107349 – dbus_connection_dispatch: Avoid using _dbus_list_foreach

[patch] dbus_connection_dispatch: Avoid using _dbus_list_foreach

0006-dbus_connection_dispatch-Avoid-using-_dbus_list_fore.patch (text/plain), 1.25 KB, created by Simon McVittie on 2018-07-23 17:12:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2018-07-23 17:12:02 UTC

Size: 1.25 KB

patch

obsolete

>From 7e97e6b2b4090caa004241a9e55d691b2b29c7c8 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <smcv@collabora.com>
>Date: Mon, 23 Jul 2018 18:02:16 +0100
>Subject: [PATCH 6/7] dbus_connection_dispatch: Avoid using _dbus_list_foreach
>
>In gcc 8, -Wall -Wextra includes -Wcast-function-type, which warns
>about passing an extra (unwanted) parameter to callbacks. Instead
>of using _dbus_list_foreach(), open-code the equivalent here.
>
>Signed-off-by: Simon McVittie <smcv@collabora.com>
>---
> dbus/dbus-connection.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
>diff --git a/dbus/dbus-connection.c b/dbus/dbus-connection.c
>index 8a5829a8..a2b35993 100644
>--- a/dbus/dbus-connection.c
>+++ b/dbus/dbus-connection.c
>@@ -4675,10 +4675,11 @@ dbus_connection_dispatch (DBusConnection *connection)
>       
>       return DBUS_DISPATCH_NEED_MEMORY;
>     }
>-  
>-  _dbus_list_foreach (&filter_list_copy,
>-		      (DBusForeachFunction)_dbus_message_filter_ref,
>-		      NULL);
>+
>+  for (link = _dbus_list_get_first_link (&filter_list_copy);
>+       link != NULL;
>+       link = _dbus_list_get_next_link (&filter_list_copy, link))
>+    _dbus_message_filter_ref (link->data);
> 
>   /* We're still protected from dispatch() reentrancy here
>    * since we acquired the dispatcher
>-- 
>2.18.0
>

Actions: View | Splinter Review

Attachments on bug 107349: 140784 | 140785 | 140786 | 140787 | 140788 | 140789 | 140790 | 140791 | 140792 | 140794

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.