Attachment 140791 Details for Bug 107349 – [1.12] build: Disable new gcc 8 warning -Wcast-function-type

[patch] [1.12] build: Disable new gcc 8 warning -Wcast-function-type

0001-build-Disable-new-gcc-8-warning-Wcast-function-type.patch (text/plain), 1.39 KB, created by Simon McVittie on 2018-07-23 17:23:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2018-07-23 17:23:31 UTC

Size: 1.39 KB

patch

obsolete

>From bb33748891b251115fc69a5ea182616ae7b54386 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <smcv@collabora.com>
>Date: Mon, 23 Jul 2018 18:20:54 +0100
>Subject: [PATCH] build: Disable new gcc 8 warning -Wcast-function-type
>
>The foreach(list, (DBusForeachFunction) free, NULL) idiom seems too
>entrenched to remove it from stable branches.
>
>Bug: https://bugs.freedesktop.org/show_bug.cgi?id=107349
>Signed-off-by: Simon McVittie <smcv@collabora.com>
>---
> configure.ac | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
>diff --git a/configure.ac b/configure.ac
>index 151cf204..5544ccef 100644
>--- a/configure.ac
>+++ b/configure.ac
>@@ -330,10 +330,14 @@ dnl - we are not going to stop using deprecated functions on a stable
> dnl   branch
> dnl - missing field initializers being 0 is a C feature, not a bug
> dnl - unused-parameter is to make writing callbacks less annoying
>+dnl - cast-function-type is for the
>+dnl   foreach(list, (DBusForeachFunction) free, NULL) idiom which would
>+dnl   be too intrusive to replace in a stable branch
> DISABLE_WARNINGS="$DISABLE_WARNINGS
>                   -Wno-deprecated-declarations
>                   -Wno-missing-field-initializers
>-                  -Wno-unused-parameter"
>+                  -Wno-unused-parameter
>+                  -Wno-cast-function-type"
> 
> if test x$enable_asserts = xno; then
>     AC_DEFINE(DBUS_DISABLE_ASSERT,1,[Disable assertion checking])
>-- 
>2.18.0
>

Actions: View | Splinter Review

Attachments on bug 107349: 140784 | 140785 | 140786 | 140787 | 140788 | 140789 | 140790 | 140791 | 140792 | 140794

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.