Attachment 140835 Details for Bug 107037 – attachment-9381-0.html

attachment-9381-0.html

attachment-9381-0.html (text/html), 3.27 KB, created by Alex Henry on 2018-07-26 13:18:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Henry

Created: 2018-07-26 13:18:00 UTC

Size: 3.27 KB

patch

obsolete

><div dir="ltr"><div>This issue is resolved now and too minor to trigger a reworking of the log system. My suggestions would be:</div><div><br></div><div>1. Do change the log message from a warning to an error regardless. Not being able to access the sound card is an error and an unexpected situation which will lead to other problems (as seen in the original complaint).</div><div><br></div><div>2. Your --started-by solution seems to be desirable on its own. I would suggest opening up a new bug report so that knowledgeable people can discuss the best solution to the current logging situation and then proceed to implement it.</div><div><br></div><div>Hopefully the combination of the two might result in better logging to this particular problem but I think #2 is out of the scope for this particular issue and should be discussed on its own merits.<br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On 29 June 2018 at 06:50,  <span dir="ltr">&lt;<a href="mailto:bugzilla-daemon@freedesktop.org" target="_blank">bugzilla-daemon@freedesktop.org</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
>    
>      
>    
>    <div>
>      <p>
>        </p><div>
>            <b><a class="m_-4136276490012012971bz_bug_link m_-4136276490012012971bz_status_RESOLVED m_-4136276490012012971bz_closed" title="RESOLVED NOTABUG - module-udev-detect fails to create sink for sound card" href="https://bugs.freedesktop.org/show_bug.cgi?id=107037#c8" target="_blank">Comment # 8</a>
>              on <a class="m_-4136276490012012971bz_bug_link m_-4136276490012012971bz_status_RESOLVED m_-4136276490012012971bz_closed" title="RESOLVED NOTABUG - module-udev-detect fails to create sink for sound card" href="https://bugs.freedesktop.org/show_bug.cgi?id=107037" target="_blank">bug 107037</a>
>              from <span class="m_-4136276490012012971vcard"><a class="m_-4136276490012012971email" href="mailto:tanuk@iki.fi" title="Tanu Kaskinen &lt;tanuk@iki.fi&gt;" target="_blank"> <span class="m_-4136276490012012971fn">Tanu Kaskinen</span></a>
></span></b>
>        <pre>I tested how the warning shows up in journalctl, and unfortunately it has no
>highlighting. Making the warning an error wouldn&#39;t help, because the problem is
>that when pulseaudio is started by systemd, the logs go to stderr. The journal
>picks up the messages from stderr, but the journal has no idea about the
>importance of the messages. PulseAudio supports logging to the journal
>directly, but unfortunately that doesn&#39;t get enabled when PulseAudio is started
>by systemd.
>
>We could pass --log-target=journal on the command line that is specified in the
>.service file, but that would make it impossible to override the log target
>from daemon.conf, so some other solution is needed. I think it would be good to
>add a --started-by=foo command line option. If it&#39;s set to &quot;systemd&quot;, we could
>then adjust the default log target based on that. The option would also provide
>useful information in &quot;ps&quot; output.</pre>
>        </div>
>      <p></p><span class="">
>
>
>      <hr>
>      <span>You are receiving this mail because:</span>
>
>      <ul>
>          <li>You reported the bug.</li>
>      </ul>
>    </span></div>
></blockquote></div><br></div>

<div dir="ltr"><div>This issue is resolved now and too minor to trigger a reworking of the log system. My suggestions would be:</div><div><br></div><div>1. Do change the log message from a warning to an error regardless. Not being able to access the sound card is an error and an unexpected situation which will lead to other problems (as seen in the original complaint).</div><div><br></div><div>2. Your --started-by solution seems to be desirable on its own. I would suggest opening up a new bug report so that knowledgeable people can discuss the best solution to the current logging situation and then proceed to implement it.</div><div><br></div><div>Hopefully the combination of the two might result in better logging to this particular problem but I think #2 is out of the scope for this particular issue and should be discussed on its own merits.<br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On 29 June 2018 at 06:50,  <span dir="ltr">&lt;<a href="mailto:bugzilla-daemon@freedesktop.org" target="_blank">bugzilla-daemon@freedesktop.org</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
    
      
    
    <div>
      <p>
        </p><div>
            <b><a class="m_-4136276490012012971bz_bug_link m_-4136276490012012971bz_status_RESOLVED m_-4136276490012012971bz_closed" title="RESOLVED NOTABUG - module-udev-detect fails to create sink for sound card" href="https://bugs.freedesktop.org/show_bug.cgi?id=107037#c8" target="_blank">Comment # 8</a>
              on <a class="m_-4136276490012012971bz_bug_link m_-4136276490012012971bz_status_RESOLVED m_-4136276490012012971bz_closed" title="RESOLVED NOTABUG - module-udev-detect fails to create sink for sound card" href="https://bugs.freedesktop.org/show_bug.cgi?id=107037" target="_blank">bug 107037</a>
              from <span class="m_-4136276490012012971vcard"><a class="m_-4136276490012012971email" href="mailto:tanuk@iki.fi" title="Tanu Kaskinen &lt;tanuk@iki.fi&gt;" target="_blank"> <span class="m_-4136276490012012971fn">Tanu Kaskinen</span></a>
</span></b>
        <pre>I tested how the warning shows up in journalctl, and unfortunately it has no
highlighting. Making the warning an error wouldn&#39;t help, because the problem is
that when pulseaudio is started by systemd, the logs go to stderr. The journal
picks up the messages from stderr, but the journal has no idea about the
importance of the messages. PulseAudio supports logging to the journal
directly, but unfortunately that doesn&#39;t get enabled when PulseAudio is started
by systemd.

We could pass --log-target=journal on the command line that is specified in the
.service file, but that would make it impossible to override the log target
from daemon.conf, so some other solution is needed. I think it would be good to
add a --started-by=foo command line option. If it&#39;s set to &quot;systemd&quot;, we could
then adjust the default log target based on that. The option would also provide
useful information in &quot;ps&quot; output.</pre>
        </div>
      <p></p><span class="">


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You reported the bug.</li>
      </ul>
    </span></div>
</blockquote></div><br></div>

Actions: View

Attachments on bug 107037: 140339 | 140835

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.