Attachment 140860 Details for Bug 107151 – This patch creates and parses the DA string in AnnotFreeText and supports RGB, CMYK and Gray color models that may be passed to poppler in setTextColor function.

[patch] This patch creates and parses the DA string in AnnotFreeText and supports RGB, CMYK and Gray color models that may be passed to poppler in setTextColor function.

Create_and_parse_DA_string_in_AnnotFreeText.patch (text/plain), 24.98 KB, created by Dileep Sankhla on 2018-07-27 22:39:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Dileep Sankhla

Created: 2018-07-27 22:39:33 UTC

Size: 24.98 KB

patch

obsolete

>diff --git poppler/Annot.cc poppler/Annot.cc
>index d37824c1..96efd130 100644
>--- poppler/Annot.cc
>+++ poppler/Annot.cc
>@@ -774,40 +774,52 @@ void AnnotColor::adjustColor(int adjust) {
>       values[i] = 0.5 * values[i] + 0.5;
>     }
>   } else if (adjust < 0) {
>     for (i = 0; i < length; ++i) {
>       values[i] = 0.5 * values[i];
>     }
>   }
> }
> 
> Object AnnotColor::writeToObject(XRef *xref) const {
>   if (length == 0) {
>     return Object(objNull); // Transparent (no color)
>   } else {
>     Array *a = new Array(xref);
>     for (int i = 0; i < length; ++i)
>       a->add( Object( values[i] ) );
>     return Object(a);
>   }
> }
> 
>+//------------------------------------------------------------------------
>+// DefaultAppearance
>+//------------------------------------------------------------------------
>+
>+DefaultAppearance::DefaultAppearance(const GooString &fontTag, int fontPtSize, AnnotColor fontColor)
>+ : fontPtSize(fontPtSize), fontColor(fontColor) {
>+  DefaultAppearance::fontTag = fontTag.copy();
>+}
>+
>+DefaultAppearance::~DefaultAppearance() {
>+  delete fontTag;
>+}
> //------------------------------------------------------------------------
> // AnnotIconFit
> //------------------------------------------------------------------------
> 
> AnnotIconFit::AnnotIconFit(Dict* dict) {
>   Object obj1;
> 
>   obj1 = dict->lookup("SW");
>   if (obj1.isName()) {
>     const char *scaleName = obj1.getName();
> 
>     if(!strcmp(scaleName, "B")) {
>       scaleWhen = scaleBigger;
>     } else if(!strcmp(scaleName, "S")) {
>       scaleWhen = scaleSmaller;
>     } else if(!strcmp(scaleName, "N")) {
>       scaleWhen = scaleNever;
>     } else {
>       scaleWhen = scaleAlways;
>     }
>@@ -2576,46 +2588,47 @@ void AnnotLink::initialize(PDFDoc *docA, Dict *dict) {
>     border = new AnnotBorderBS(obj1.getDict());
>   } else if (!border) {
>     border = new AnnotBorderBS();
>   }
> }
> 
> void AnnotLink::draw(Gfx *gfx, GBool printing) {
>   if (!isVisible (printing))
>     return;
> 
>   annotLocker();
>   // draw the appearance stream
>   Object obj = appearance.fetch(gfx->getXRef());
>   gfx->drawAnnot(&obj, border, color,
> 		 rect->x1, rect->y1, rect->x2, rect->y2, getRotation());
> }
> 
> //------------------------------------------------------------------------
> // AnnotFreeText
> //------------------------------------------------------------------------
>-AnnotFreeText::AnnotFreeText(PDFDoc *docA, PDFRectangle *rect, GooString *da) :
>+AnnotFreeText::AnnotFreeText(PDFDoc *docA, PDFRectangle *rect, const DefaultAppearance &da) :
>     AnnotMarkup(docA, rect) {
>   type = typeFreeText;
> 
>+  GooString *daStr = constructAppearanceString(*da.fontTag, da.fontPtSize, da.fontColor);
>   annotObj.dictSet ("Subtype", Object(objName, "FreeText"));
>-  annotObj.dictSet("DA", Object(da->copy()));
>+  annotObj.dictSet("DA", Object(daStr));
> 
>   initialize (docA, annotObj.getDict());
> }
> 
> AnnotFreeText::AnnotFreeText(PDFDoc *docA, Object *dictObject, Object *obj) :
>     AnnotMarkup(docA, dictObject, obj) {
>   type = typeFreeText;
>   initialize(docA, dictObject->getDict());
> }
> 
> AnnotFreeText::~AnnotFreeText() {
>   delete appearanceString;
> 
>   if (styleString)
>     delete styleString;
> 
>   if (calloutLine)
>     delete calloutLine;
> 
>   if (borderEffect)
>@@ -2709,48 +2722,44 @@ void AnnotFreeText::initialize(PDFDoc *docA, Dict *dict) {
>   if (obj1.isArray()) {
>     rectangle = parseDiffRectangle(obj1.getArray(), rect);
>   } else {
>     rectangle = nullptr;
>   }
> 
>   obj1 = dict->lookup("LE");
>   if (obj1.isName()) {
>     GooString styleName(obj1.getName());
>     endStyle = parseAnnotLineEndingStyle(&styleName);
>   } else {
>     endStyle = annotLineEndingNone;
>   }
> }
> 
> void AnnotFreeText::setContents(GooString *new_content) {
>   Annot::setContents(new_content);
>   invalidateAppearance();
> }
> 
>-void AnnotFreeText::setAppearanceString(GooString *new_string) {
>+void AnnotFreeText::setAppearanceString(const DefaultAppearance &da) {
>   delete appearanceString;
> 
>-  if (new_string) {
>-    appearanceString = new GooString(new_string);
>-  } else {
>-    appearanceString = new GooString();
>-  }
>+  appearanceString = constructAppearanceString(*da.fontTag, da.fontPtSize, da.fontColor);
> 
>   update ("DA", Object(appearanceString->copy()));
>   invalidateAppearance();
> }
> 
> void AnnotFreeText::setQuadding(AnnotFreeTextQuadding new_quadding) {
>   quadding = new_quadding;
>   update ("Q", Object((int)quadding));
>   invalidateAppearance();
> }
> 
> void AnnotFreeText::setStyleString(GooString *new_string) {
>   delete styleString;
> 
>   if (new_string) {
>     styleString = new GooString(new_string);
>     //append the unicode marker <FE FF> if needed
>     if (!styleString->hasUnicodeMarker()) {
>       styleString->prependUnicodeMarker();
>     }
>@@ -2788,57 +2797,75 @@ void AnnotFreeText::setCalloutLine(AnnotCalloutLine *line) {
>     }
>   }
> 
>   update("CL", std::move(obj1));
>   invalidateAppearance();
> }
> 
> void AnnotFreeText::setIntent(AnnotFreeTextIntent new_intent) {
>   const char *intentName;
> 
>   intent = new_intent;
>   if (new_intent == intentFreeText)
>     intentName = "FreeText";
>   else if (new_intent == intentFreeTextCallout)
>     intentName = "FreeTextCallout";
>   else // intentFreeTextTypeWriter
>     intentName = "FreeTextTypeWriter";
>   update ("IT", Object(objName, intentName));
> }
> 
>-static GfxFont * createAnnotDrawFont(XRef * xref, Dict *fontResDict)
>+DefaultAppearance AnnotFreeText::getAppearanceString() const {
>+  double fontSize;
>+  AnnotColor *fontColor;
>+  parseAppearanceString(appearanceString, fontSize, fontColor);
>+  return DefaultAppearance(GooString("Invalid_font"), fontSize, *fontColor);
>+}
>+
>+static GfxFont *createAnnotDrawFont(XRef * xref, Dict *fontResDict)
> {
>   const Ref dummyRef = { -1, -1 };
> 
>   Dict *fontDict = new Dict(xref);
>   fontDict->add(copyString("BaseFont"), Object(objName, "Helvetica"));
>   fontDict->add(copyString("Subtype"), Object(objName, "Type0"));
>   fontDict->add(copyString("Encoding"), Object(objName, "WinAnsiEncoding"));
> 
>   Dict *fontsDict = new Dict(xref);
>   fontsDict->add(copyString("AnnotDrawFont"), Object(fontDict));
> 
>   fontResDict->add(copyString("Font"), Object(fontsDict));
> 
>   return GfxFont::makeFont(xref, "AnnotDrawFont", dummyRef, fontDict);
> }
> 
>+GooString *AnnotFreeText::constructAppearanceString(const GooString &fontTag, double fontSize, const AnnotColor &fontColor) {
>+  const double *colorData = fontColor.getValues();
>+  AnnotColor::AnnotColorSpace colorSpace = fontColor.getSpace();
>+  if (colorSpace == AnnotColor::AnnotColorSpace::colorRGB)
>+    return GooString::format("{0:.2f} {1:.2f} {2:.2f} rg /{3:s} {4:.2f} Tf", colorData[0], colorData[1], colorData[2], &fontTag, fontSize);
>+  else if (colorSpace == AnnotColor::AnnotColorSpace::colorCMYK)
>+    return GooString::format("{0:.2f} {1:.2f} {2:.2f} {3:.2f} k /{4:s} {5:.2f} Tf", colorData[0], colorData[1], colorData[2], colorData[3], &fontTag, fontSize);
>+  else
>+    return GooString::format("{0:.2f} g /{1:s} {2:.2f} Tf", colorData[0], &fontTag, fontSize);
>+}
>+
> void AnnotFreeText::parseAppearanceString(GooString *da, double &fontsize, AnnotColor* &fontcolor) {
>   fontsize = -1;
>   fontcolor = nullptr;
>   if (da) {
>     GooList * daToks = new GooList();
>     int i = FormFieldText::tokenizeDA(da, daToks, "Tf");
> 
>     if (i >= 1) {
>       fontsize = gatof(( (GooString *)daToks->get(i-1) )->getCString());
>       // TODO: Font name
>     }
>     // Scan backwards: we are looking for the last set value
>     for (i = daToks->getLength()-1; i >= 0; --i) {
>       if (fontcolor == nullptr) {
>         if (!((GooString *)daToks->get(i))->cmp("g") && i >= 1) {
>           fontcolor = new AnnotColor(gatof(( (GooString *)daToks->get(i-1) )->getCString()));
>         } else if (!((GooString *)daToks->get(i))->cmp("rg") && i >= 3) {
>           fontcolor = new AnnotColor(gatof(( (GooString *)daToks->get(i-3) )->getCString()),
>                                      gatof(( (GooString *)daToks->get(i-2) )->getCString()),
>                                      gatof(( (GooString *)daToks->get(i-1) )->getCString()));
>diff --git poppler/Annot.h poppler/Annot.h
>index 83c10b39..0cbeb4f4 100644
>--- poppler/Annot.h
>+++ poppler/Annot.h
>@@ -330,40 +330,52 @@ public:
> 
>   AnnotColor();
>   AnnotColor(double gray);
>   AnnotColor(double r, double g, double b);
>   AnnotColor(double c, double m, double y, double k);
>   AnnotColor(Array *array, int adjust = 0);
> 
>   void adjustColor(int adjust);
> 
>   AnnotColorSpace getSpace() const { return (AnnotColorSpace) length; }
>   const double *getValues() const { return values; }
> 
>   Object writeToObject(XRef *xref) const;
> 
> private:
> 
>   double values[4];
>   int length;
> };
> 
>+//------------------------------------------------------------------------
>+// DefaultAppearance
>+//------------------------------------------------------------------------
>+
>+struct DefaultAppearance {
>+  DefaultAppearance(const GooString &fontTag, int fontPtSize, AnnotColor fontColor);
>+  ~DefaultAppearance();
>+  GooString *fontTag;
>+  int fontPtSize;
>+  AnnotColor fontColor;
>+};
>+
> //------------------------------------------------------------------------
> // AnnotIconFit
> //------------------------------------------------------------------------
> 
> class AnnotIconFit {
> public:
> 
>   enum AnnotIconFitScaleWhen {
>     scaleAlways,  // A
>     scaleBigger,  // B
>     scaleSmaller, // S
>     scaleNever    // N
>   };
> 
>   enum AnnotIconFitScale {
>     scaleAnamorphic,  // A
>     scaleProportional // P
>   };
> 
>   AnnotIconFit(Dict *dict);
>@@ -952,69 +964,70 @@ protected:
> 
> //------------------------------------------------------------------------
> // AnnotFreeText
> //------------------------------------------------------------------------
> 
> class AnnotFreeText: public AnnotMarkup {
> public:
> 
>   enum AnnotFreeTextQuadding {
>     quaddingLeftJustified,  // 0
>     quaddingCentered,       // 1
>     quaddingRightJustified  // 2
>   };
> 
>   enum AnnotFreeTextIntent {
>     intentFreeText,           // FreeText
>     intentFreeTextCallout,    // FreeTextCallout
>     intentFreeTextTypeWriter  // FreeTextTypeWriter
>   };
> 
>-  AnnotFreeText(PDFDoc *docA, PDFRectangle *rect, GooString *da);
>+  AnnotFreeText(PDFDoc *docA, PDFRectangle *rect, const DefaultAppearance &da);
>   AnnotFreeText(PDFDoc *docA, Object *dictObject, Object *obj);
>   ~AnnotFreeText();
> 
>   void draw(Gfx *gfx, GBool printing) override;
>   Object getAppearanceResDict() override;
>   void setContents(GooString *new_content) override;
> 
>-  void setAppearanceString(GooString *new_string);
>+  void setAppearanceString(const DefaultAppearance &da);
>   void setQuadding(AnnotFreeTextQuadding new_quadding);
>   void setStyleString(GooString *new_string);
>   void setCalloutLine(AnnotCalloutLine *line);
>   void setIntent(AnnotFreeTextIntent new_intent);
> 
>   // getters
>-  const GooString *getAppearanceString() const { return appearanceString; }
>+  DefaultAppearance getAppearanceString() const;
>   AnnotFreeTextQuadding getQuadding() const { return quadding; }
>   // return rc
>   const GooString *getStyleString() const { return styleString; }
>   AnnotCalloutLine *getCalloutLine() const {  return calloutLine; }
>   AnnotFreeTextIntent getIntent() const { return intent; }
>   AnnotBorderEffect *getBorderEffect() const { return borderEffect; }
>   PDFRectangle *getRectangle() const { return rectangle; }
>   AnnotLineEndingStyle getEndStyle() const { return endStyle; }
> 
> protected:
> 
>   void initialize(PDFDoc *docA, Dict *dict);
>-  static void parseAppearanceString(GooString *da, double &fontsize, AnnotColor* &fontcolor);
>+  static GooString *constructAppearanceString(const GooString &fontTag, double fontSize, const AnnotColor &fontColor);
>+  static void parseAppearanceString(GooString *da, double &fontSize, AnnotColor* &fontColor);
>   void generateFreeTextAppearance();
> 
>   // required
>   GooString *appearanceString;      // DA
> 
>   // optional
>   AnnotFreeTextQuadding quadding;   // Q  (Default 0)
>   // RC
>   GooString *styleString;           // DS
>   AnnotCalloutLine *calloutLine;    // CL
>   AnnotFreeTextIntent intent;       // IT
>   AnnotBorderEffect *borderEffect;  // BE
>   PDFRectangle *rectangle;          // RD
>   // inherited  from Annot
>   // AnnotBorderBS border;          // BS
>   AnnotLineEndingStyle endStyle;    // LE (Default None)
> };
> 
> //------------------------------------------------------------------------
> // AnnotLine
>diff --git qt5/src/poppler-annotation.cc qt5/src/poppler-annotation.cc
>index 5550efcd..cd809229 100644
>--- qt5/src/poppler-annotation.cc
>+++ qt5/src/poppler-annotation.cc
>@@ -1799,140 +1799,163 @@ QList<Annotation*> Annotation::revisions() const
>     }
> 
>     /* If the annotation doesn't live in a object on its own (eg bug51361), it
>      * has no ref, therefore it can't have revisions */
>     if ( !d->pdfAnnot->getHasRef() )
>         return QList<Annotation*>();
> 
>     return AnnotationPrivate::findAnnotations( d->pdfPage, d->parentDoc, QSet<Annotation::SubType>(), d->pdfAnnot->getId() );
> }
> 
> //END Annotation implementation
> 
> 
> /** TextAnnotation [Annotation] */
> class TextAnnotationPrivate : public AnnotationPrivate
> {
>     public:
>         TextAnnotationPrivate();
>         Annotation * makeAlias() override;
>         Annot* createNativeAnnot(::Page *destPage, DocumentData *doc) override;
>+        void setDefaultAppearance();
>+        DefaultAppearance getDefaultAppearance() const;
> 
>         // data fields
>         TextAnnotation::TextType textType;
>         QString textIcon;
>         QFont textFont;
>+        QColor textColor;
>         int inplaceAlign; // 0:left, 1:center, 2:right
>         QVector<QPointF> inplaceCallout;
>         TextAnnotation::InplaceIntent inplaceIntent;
>-
>-        // Helper
>-        static GooString * toAppearanceString(const QFont &font);
> };
> 
> TextAnnotationPrivate::TextAnnotationPrivate()
>     : AnnotationPrivate(), textType( TextAnnotation::Linked ),
>     textIcon( QStringLiteral("Note") ), inplaceAlign( 0 ),
>     inplaceIntent( TextAnnotation::Unknown )
> {
> }
> 
> Annotation * TextAnnotationPrivate::makeAlias()
> {
>     return new TextAnnotation(*this);
> }
> 
>-GooString * TextAnnotationPrivate::toAppearanceString(const QFont &font)
>-{
>-    GooString * s = GooString::format("/Invalid_font {0:d} Tf", font.pointSize());
>-    // TODO: Font family, style (bold, italic, ...) and pointSize as float
>-    return s;
>-}
>-
> Annot* TextAnnotationPrivate::createNativeAnnot(::Page *destPage, DocumentData *doc)
> {
>     // Setters are defined in the public class
>     TextAnnotation *q = static_cast<TextAnnotation*>( makeAlias() );
> 
>     // Set page and contents
>     pdfPage = destPage;
>     parentDoc = doc;
> 
>     // Set pdfAnnot
>     PDFRectangle rect = boundaryToPdfRectangle(boundary, flags);
>     if (textType == TextAnnotation::Linked)
>     {
>         pdfAnnot = new AnnotText(destPage->getDoc(), &rect);
>     }
>     else
>     {
>-        GooString * da = toAppearanceString(textFont);
>+        DefaultAppearance da(GooString("Invalid_font"), textFont.pointSize(),
>+                             AnnotColor(textColor.redF(), textColor.greenF(), textColor.blueF()));
>         pdfAnnot = new AnnotFreeText(destPage->getDoc(), &rect, da);
>-        delete da;
>     }
> 
>     // Set properties
>     flushBaseAnnotationProperties();
>     q->setTextIcon(textIcon);
>     q->setInplaceAlign(inplaceAlign);
>     q->setCalloutPoints(inplaceCallout);
>     q->setInplaceIntent(inplaceIntent);
> 
>     delete q;
> 
>     inplaceCallout.clear(); // Free up memory
> 
>     return pdfAnnot;
> }
> 
>+DefaultAppearance TextAnnotationPrivate::getDefaultAppearance() const
>+{
>+    AnnotFreeText * ftextann = static_cast<AnnotFreeText*>(pdfAnnot);
>+    return ftextann->getAppearanceString();
>+}
>+
>+void TextAnnotationPrivate::setDefaultAppearance()
>+{
>+  if (textColor.spec() == QColor::Rgb)
>+  {
>+    DefaultAppearance da(GooString("Invalid_font"), textFont.pointSize(),
>+                         AnnotColor(textColor.redF(), textColor.greenF(), textColor.blueF()));
>+    AnnotFreeText * ftextann = static_cast<AnnotFreeText*>(pdfAnnot);
>+    ftextann->setAppearanceString(da);
>+  }
>+  else if (textColor.spec() == QColor::Cmyk)
>+  {
>+	DefaultAppearance da(GooString("Invalid_font"), textFont.pointSize(),
>+	                     AnnotColor(textColor.cyanF(), textColor.magentaF(), textColor.yellowF(), textColor.blackF()));
>+    AnnotFreeText * ftextann = static_cast<AnnotFreeText*>(pdfAnnot);
>+    ftextann->setAppearanceString(da);
>+  }
>+}
>+
> TextAnnotation::TextAnnotation( TextAnnotation::TextType type )
>     : Annotation( *new TextAnnotationPrivate() )
> {
>     setTextType( type );
> }
> 
> TextAnnotation::TextAnnotation(TextAnnotationPrivate &dd)
>     : Annotation( dd )
> {}
> 
> TextAnnotation::TextAnnotation( const QDomNode & node )
>     : Annotation( *new TextAnnotationPrivate, node )
> {
>     // loop through the whole children looking for a 'text' element
>     QDomNode subNode = node.firstChild();
>     while( subNode.isElement() )
>     {
>         QDomElement e = subNode.toElement();
>         subNode = subNode.nextSibling();
>         if ( e.tagName() != QLatin1String("text") )
>             continue;
> 
>         // parse the attributes
>         if ( e.hasAttribute( QStringLiteral("type") ) )
>             setTextType((TextAnnotation::TextType)e.attribute( QStringLiteral("type") ).toInt());
>         if ( e.hasAttribute( QStringLiteral("icon") ) )
>             setTextIcon(e.attribute( QStringLiteral("icon") ));
>         if ( e.hasAttribute( QStringLiteral("font") ) )
>         {
>             QFont font;
>             font.fromString( e.attribute( QStringLiteral("font") ) );
>             setTextFont(font);
>+            if ( e.hasAttribute( QStringLiteral("fontColor") ) )
>+            {
>+                QColor color;
>+                color = QColor(e.attribute( QStringLiteral("fontColor") ) );
>+                setTextColor(color);
>+            }
>         }
>         if ( e.hasAttribute( QStringLiteral("align") ) )
>             setInplaceAlign(e.attribute( QStringLiteral("align") ).toInt());
>         if ( e.hasAttribute( QStringLiteral("intent") ) )
>             setInplaceIntent((TextAnnotation::InplaceIntent)e.attribute( QStringLiteral("intent") ).toInt());
> 
>         // parse the subnodes
>         QDomNode eSubNode = e.firstChild();
>         while ( eSubNode.isElement() )
>         {
>             QDomElement ee = eSubNode.toElement();
>             eSubNode = eSubNode.nextSibling();
> 
>             if ( ee.tagName() == QLatin1String("escapedText") )
>             {
>                 setContents(ee.firstChild().toCDATASection().data());
>             }
>             else if ( ee.tagName() == QLatin1String("callout") )
>             {
>                 QVector<QPointF> points(3);
>@@ -1958,40 +1981,41 @@ TextAnnotation::~TextAnnotation()
> void TextAnnotation::store( QDomNode & node, QDomDocument & document ) const
> {
>     // store base annotation properties
>     storeBaseAnnotationProperties( node, document );
> 
>     // create [text] element
>     QDomElement textElement = document.createElement( QStringLiteral("text") );
>     node.appendChild( textElement );
> 
>     // store the optional attributes
>     if ( textType() != Linked )
>         textElement.setAttribute( QStringLiteral("type"), (int)textType() );
>     if ( textIcon() != QLatin1String("Note") )
>         textElement.setAttribute( QStringLiteral("icon"), textIcon() );
>     if ( inplaceAlign() )
>         textElement.setAttribute( QStringLiteral("align"), inplaceAlign() );
>     if ( inplaceIntent() != Unknown )
>         textElement.setAttribute( QStringLiteral("intent"), (int)inplaceIntent() );
> 
>     textElement.setAttribute( QStringLiteral("font"), textFont().toString() );
>+    textElement.setAttribute( QStringLiteral("fontColor"), textColor().name() );
> 
>     // Sub-Node-1 - escapedText
>     if ( !contents().isEmpty() )
>     {
>         QDomElement escapedText = document.createElement( QStringLiteral("escapedText") );
>         textElement.appendChild( escapedText );
>         QDomCDATASection textCData = document.createCDATASection( contents() );
>         escapedText.appendChild( textCData );
>     }
> 
>     // Sub-Node-2 - callout
>     if ( calloutPoint(0).x() != 0.0 )
>     {
>         QDomElement calloutElement = document.createElement( QStringLiteral("callout") );
>         textElement.appendChild( calloutElement );
>         calloutElement.setAttribute( QStringLiteral("ax"), QString::number( calloutPoint(0).x() ) );
>         calloutElement.setAttribute( QStringLiteral("ay"), QString::number( calloutPoint(0).y() ) );
>         calloutElement.setAttribute( QStringLiteral("bx"), QString::number( calloutPoint(1).x() ) );
>         calloutElement.setAttribute( QStringLiteral("by"), QString::number( calloutPoint(1).y() ) );
>         calloutElement.setAttribute( QStringLiteral("cx"), QString::number( calloutPoint(2).x() ) );
>@@ -2057,73 +2081,92 @@ void TextAnnotation::setTextIcon( const QString &icon )
>     if (d->pdfAnnot->getType() == Annot::typeText)
>     {
>         AnnotText * textann = static_cast<AnnotText*>(d->pdfAnnot);
>         QByteArray encoded = icon.toLatin1();
>         GooString s(encoded.constData());
>         textann->setIcon(&s);
>     }
> }
> 
> QFont TextAnnotation::textFont() const
> {
>     Q_D( const TextAnnotation );
> 
>     if (!d->pdfAnnot)
>         return d->textFont;
> 
>     QFont font;
> 
>     if (d->pdfAnnot->getType() == Annot::typeFreeText)
>     {
>-        const AnnotFreeText * ftextann = static_cast<const AnnotFreeText*>(d->pdfAnnot);
>-        const GooString * da = ftextann->getAppearanceString();
>-        if (da)
>-        {
>-            // At the moment, only font size is parsed
>-            QString style = QString::fromLatin1( da->getCString() );
>-            QRegExp rx(QStringLiteral("(\\d+)(\\.\\d*)? Tf"));
>-            if (rx.indexIn(style) != -1)
>-                font.setPointSize( rx.cap(1).toInt() );
>-            // TODO: Other properties
>-        }
>+        DefaultAppearance da = d->getDefaultAppearance();
>+        font.setPointSize( da.fontPtSize );
>     }
> 
>     return font;
> }
> 
> void TextAnnotation::setTextFont( const QFont &font )
> {
>     Q_D( TextAnnotation );
> 
>+    d->textFont = font;
>+    d->textColor = QColor(0, 0, 0).convertTo(QColor::Rgb); // black
>+
>+    if (!d->pdfAnnot || d->pdfAnnot->getType() != Annot::typeFreeText)
>+        return;
>+
>+    d->setDefaultAppearance();
>+}
>+
>+QColor TextAnnotation::textColor() const
>+{
>+    Q_D( const TextAnnotation );
>+
>     if (!d->pdfAnnot)
>+        return d->textColor;
>+
>+    QColor color;
>+
>+    if (d->pdfAnnot->getType() == Annot::typeFreeText)
>     {
>-        d->textFont = font;
>-        return;
>+        DefaultAppearance da = d->getDefaultAppearance();
>+        const double *colorData = da.fontColor.getValues();
>+        if (da.fontColor.getSpace() == AnnotColor::AnnotColorSpace::colorRGB)
>+          color.setRgbF(colorData[0], colorData[1], colorData[2]);
>+        else if (da.fontColor.getSpace() == AnnotColor::AnnotColorSpace::colorCMYK)
>+          color.setCmykF(colorData[0], colorData[1], colorData[2], colorData[3]);
>     }
> 
>-    if (d->pdfAnnot->getType() != Annot::typeFreeText)
>+    return color;
>+}
>+
>+void TextAnnotation::setTextColor( const QColor &color )
>+{
>+    Q_D( TextAnnotation );
>+
>+    d->textColor = color;
>+
>+    if (!d->pdfAnnot || d->pdfAnnot->getType() != Annot::typeFreeText)
>         return;
> 
>-    AnnotFreeText * ftextann = static_cast<AnnotFreeText*>(d->pdfAnnot);
>-    GooString * da = TextAnnotationPrivate::toAppearanceString(font);
>-    ftextann->setAppearanceString(da);
>-    delete da;
>+    d->setDefaultAppearance();
> }
> 
> int TextAnnotation::inplaceAlign() const
> {
>     Q_D( const TextAnnotation );
> 
>     if (!d->pdfAnnot)
>         return d->inplaceAlign;
> 
>     if (d->pdfAnnot->getType() == Annot::typeFreeText)
>     {
>         const AnnotFreeText * ftextann = static_cast<const AnnotFreeText*>(d->pdfAnnot);
>         return ftextann->getQuadding();
>     }
> 
>     return 0;
> }
> 
> void TextAnnotation::setInplaceAlign( int align )
> {
>diff --git qt5/src/poppler-annotation.h qt5/src/poppler-annotation.h
>index a70cbe4f..63bf79ae 100644
>--- qt5/src/poppler-annotation.h
>+++ qt5/src/poppler-annotation.h
>@@ -467,40 +467,42 @@ class POPPLER_QT5_EXPORT TextAnnotation : public Annotation
>        Standard names for text annotation icons are:
>        - Comment
>        - Help
>        - Insert
>        - Key
>        - NewParagraph
>        - Note (this is the default icon to use)
>        - Paragraph
>     */
>     QString textIcon() const;
> 
>     /**
>        Set the name of the icon to use for this text annotation.
> 
>        \sa textIcon for the list of standard names
>     */
>     void setTextIcon( const QString &icon );
> 
>     QFont textFont() const;
>     void setTextFont( const QFont &font );
>+    QColor textColor() const;
>+    void setTextColor( const QColor &color );
> 
>     int inplaceAlign() const;
>     void setInplaceAlign( int align );
> 
>     QPointF calloutPoint( int id ) const;
>     /// \since 0.20
>     QVector<QPointF> calloutPoints() const;
>     /// \since 0.20
>     void setCalloutPoints( const QVector<QPointF> &points );
> 
>     InplaceIntent inplaceIntent() const;
>     void setInplaceIntent( InplaceIntent intent );
> 
>   private:
>     TextAnnotation( const QDomNode &node );
>     TextAnnotation( TextAnnotationPrivate &dd );
>     void store( QDomNode &parentNode, QDomDocument &document ) const override;
>     void setTextType( TextType type );
>     Q_DECLARE_PRIVATE( TextAnnotation )
>     Q_DISABLE_COPY( TextAnnotation )

Actions: View | Splinter Review

Attachments on bug 107151: 140496 | 140512 | 140860 | 140935 | 140963 | 141142

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.