Attachment 140905 Details for Bug 107432 – Use kvmalloc in amdgpu_uvd_suspend

[patch] Use kvmalloc in amdgpu_uvd_suspend

amdgpu_uvd_suspend-kvmalloc.diff (text/plain), 1.24 KB, created by Michel Dänzer on 2018-07-31 09:09:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Michel Dänzer

Created: 2018-07-31 09:09:51 UTC

Size: 1.24 KB

patch

obsolete

>diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
>index 632fa5980ff4..5564e5bb03d6 100644
>--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
>+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
>@@ -311,7 +311,7 @@ int amdgpu_uvd_sw_fini(struct amdgpu_device *adev)
> 	for (j = 0; j < adev->uvd.num_uvd_inst; ++j) {
> 		if (adev->uvd.harvest_config & (1 << j))
> 			continue;
>-		kfree(adev->uvd.inst[j].saved_bo);
>+		kvfree(adev->uvd.inst[j].saved_bo);
> 
> 		amdgpu_bo_free_kernel(&adev->uvd.inst[j].vcpu_bo,
> 				      &adev->uvd.inst[j].gpu_addr,
>@@ -354,7 +354,7 @@ int amdgpu_uvd_suspend(struct amdgpu_device *adev)
> 		size = amdgpu_bo_size(adev->uvd.inst[j].vcpu_bo);
> 		ptr = adev->uvd.inst[j].cpu_addr;
> 
>-		adev->uvd.inst[j].saved_bo = kmalloc(size, GFP_KERNEL);
>+		adev->uvd.inst[j].saved_bo = kvmalloc(size, GFP_KERNEL);
> 		if (!adev->uvd.inst[j].saved_bo)
> 			return -ENOMEM;
> 
>@@ -380,7 +380,7 @@ int amdgpu_uvd_resume(struct amdgpu_device *adev)
> 
> 		if (adev->uvd.inst[i].saved_bo != NULL) {
> 			memcpy_toio(ptr, adev->uvd.inst[i].saved_bo, size);
>-			kfree(adev->uvd.inst[i].saved_bo);
>+			kvfree(adev->uvd.inst[i].saved_bo);
> 			adev->uvd.inst[i].saved_bo = NULL;
> 		} else {
> 			const struct common_firmware_header *hdr;

Actions: View | Splinter Review

Attachments on bug 107432: 140902 | 140903 | 140905 | 140932

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.