Attachment 141104 Details for Bug 107552 – Possible fix

[patch] Possible fix

0001-amdgpu-fix-off-by-one-in-handle_table_insert.patch (text/plain), 1.03 KB, created by Christian König on 2018-08-15 11:57:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Christian König

Created: 2018-08-15 11:57:54 UTC

Size: 1.03 KB

patch

obsolete

>From ed719d9d1e0855e4d9b23d190acff84c66c1bb6a Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>
>Date: Wed, 15 Aug 2018 13:25:14 +0200
>Subject: [PATCH libdrm] amdgpu: fix off by one in handle_table_insert
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Stupid me, max_key must always be larger than key.
>
>Signed-off-by: Christian KÃ¶nig <christian.koenig@amd.com>
>---
> amdgpu/handle_table.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/amdgpu/handle_table.c b/amdgpu/handle_table.c
>index 15cd4763..4fdd29d3 100644
>--- a/amdgpu/handle_table.c
>+++ b/amdgpu/handle_table.c
>@@ -33,7 +33,7 @@ drm_private int handle_table_insert(struct handle_table *table, uint32_t key,
> {
> 	if (key >= table->max_key) {
> 		uint32_t alignment = sysconf(_SC_PAGESIZE) / sizeof(void*);
>-		uint32_t max_key = ALIGN(key, alignment);
>+		uint32_t max_key = ALIGN(key + 1, alignment);
> 		void **values;
> 
> 		values = realloc(table->values, max_key * sizeof(void *));
>-- 
>2.17.1
>

Actions: View | Splinter Review

Attachments on bug 107552: 141104

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.