Attachment 141463 Details for Bug 107314 – [RFC PATCH xserver] xwayland: ignore sync callback if window is destroyed

[patch] [RFC PATCH xserver] xwayland: ignore sync callback if window is destroyed

0001-xwayland-ignore-sync-callback-if-window-is-destroyed.patch (text/plain), 1.25 KB, created by Olivier Fourdan on 2018-09-05 17:04:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Olivier Fourdan

Created: 2018-09-05 17:04:44 UTC

Size: 1.25 KB

patch

obsolete

>From 04b127cb702b4dc5a6de835c250135310e7db1f4 Mon Sep 17 00:00:00 2001
>From: Olivier Fourdan <ofourdan@redhat.com>
>Date: Wed, 5 Sep 2018 13:08:03 +0200
>Subject: [RFC PATCH xserver] xwayland: ignore sync callback if window is destroyed
>
>If the window is destroyed, there is no need to send the vblank notify
>event.
>
>This should avoid a crash in present_vblank_notify() if the sync
>callback is triggered after the Xwayland window is destroyed.
>
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107314
>Signed-off-by: Olivier Fourdan <ofourdan@redhat.com>
>---
> v2: Don't leak the event.
>     This goes along with   https://patchwork.freedesktop.org/patch/247271/
> hw/xwayland/xwayland-present.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/hw/xwayland/xwayland-present.c b/hw/xwayland/xwayland-present.c
>index 316e04443..4d65e3807 100644
>--- a/hw/xwayland/xwayland-present.c
>+++ b/hw/xwayland/xwayland-present.c
>@@ -284,6 +284,10 @@ xwl_present_sync_callback(void *data,
>         return;
>     }
> 
>+    /* Is the window destroyed already ? */
>+    if (!xwl_present_window)
>+        return;
>+
>     present_wnmd_event_notify(xwl_present_window->window,
>                               event->event_id,
>                               xwl_present_window->ust,
>-- 
>2.17.1
>

Actions: View | Splinter Review

Attachments on bug 107314: 141273 | 141463

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.