Attachment 142653 Details for Bug 108825 – v2-0001-drm-amd-display-Fix-unintialized-max_bpc-state-va.patch

[patch] v2-0001-drm-amd-display-Fix-unintialized-max_bpc-state-va.patch

v2-0001-drm-amd-display-Fix-unintialized-max_bpc-state-va.patch (text/plain), 1.70 KB, created by Nicholas Kazlauskas on 2018-11-28 21:33:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nicholas Kazlauskas

Created: 2018-11-28 21:33:43 UTC

Size: 1.70 KB

patch

obsolete

>From 9b4184241c9388a99dc8821f755aa224eee86f77 Mon Sep 17 00:00:00 2001
>From: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
>Date: Wed, 28 Nov 2018 16:17:50 -0500
>Subject: [PATCH v2] drm/amd/display: Fix unintialized max_bpc state values
>
>[Why]
>If the "max bpc" isn't explicitly set in the atomic state then it
>have a value of 0. This has the correct behavior of limiting a panel
>to 8bpc in the case where the panel supports 8bpc. In the case of eDP
>panels this isn't a true assumption - there are panels that can only
>do 6bpc.
>
>Banding occurs for these displays.
>
>[How]
>Initialize the max_bpc when the connector resets to 8bpc. Also carry
>over the value when the state is duplicated.
>
>Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
>---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>index 21709e4d8595..cb23c02dae84 100644
>--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>@@ -3299,6 +3299,7 @@ void amdgpu_dm_connector_funcs_reset(struct drm_connector *connector)
> 		state->underscan_enable = false;
> 		state->underscan_hborder = 0;
> 		state->underscan_vborder = 0;
>+		state->max_bpc = 8;
> 
> 		__drm_atomic_helper_connector_reset(connector, &state->base);
> 	}
>@@ -3321,6 +3322,7 @@ amdgpu_dm_connector_atomic_duplicate_state(struct drm_connector *connector)
> 	new_state->freesync_capable = state->freesync_capable;
> 	new_state->freesync_enable = state->freesync_enable;
> 	new_state->abm_level = state->abm_level;
>+	new_state->max_bpc = cur->max_bpc;
> 
> 	return &new_state->base;
> }
>-- 
>2.19.2
>

Actions: View | Splinter Review

Attachments on bug 108825: 142561 | 142562 | 142563 | 142652 | 142653

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.