Attachment 142693 Details for Bug 108920 – possible fix

[patch] possible fix

0001-drm-amdgpu-si-fix-SI-after-doorbell-rework.patch (text/plain), 1.37 KB, created by Alex Deucher on 2018-12-03 02:50:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Deucher

Created: 2018-12-03 02:50:51 UTC

Size: 1.37 KB

patch

obsolete

>From d14e3ddc87f3c5bbdaba19ef7a809cbdbe176cd7 Mon Sep 17 00:00:00 2001
>From: Alex Deucher <alexander.deucher@amd.com>
>Date: Sun, 2 Dec 2018 21:47:42 -0500
>Subject: [PATCH] drm/amdgpu/si: fix SI after doorbell rework
>
>SI does not use doorbells, move asic doorbell init later
>asic check.
>
>Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=108920
>Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
>---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>index c75badfa5c4c..5a72906fdc6b 100644
>--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>@@ -515,7 +515,6 @@ void amdgpu_device_pci_config_reset(struct amdgpu_device *adev)
>  */
> static int amdgpu_device_doorbell_init(struct amdgpu_device *adev)
> {
>-	amdgpu_asic_init_doorbell_index(adev);
> 
> 	/* No doorbell on SI hardware generation */
> 	if (adev->asic_type < CHIP_BONAIRE) {
>@@ -529,6 +528,8 @@ static int amdgpu_device_doorbell_init(struct amdgpu_device *adev)
> 	if (pci_resource_flags(adev->pdev, 2) & IORESOURCE_UNSET)
> 		return -EINVAL;
> 
>+	amdgpu_asic_init_doorbell_index(adev);
>+
> 	/* doorbell bar mapping */
> 	adev->doorbell.base = pci_resource_start(adev->pdev, 2);
> 	adev->doorbell.size = pci_resource_len(adev->pdev, 2);
>-- 
>2.13.6
>

Actions: View | Splinter Review

Attachments on bug 108920: 142693

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.