Attachment 143082 Details for Bug 109242 – Possible fix partial_vs_wave

[patch] Possible fix partial_vs_wave

0001-radv-Set-partial_vs_wave-even-for-parts-without-dist.patch (text/plain), 2.23 KB, created by Bas Nieuwenhuizen on 2019-01-12 20:26:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Bas Nieuwenhuizen

Created: 2019-01-12 20:26:33 UTC

Size: 2.23 KB

patch

obsolete

>From e6900e1af24520cb94e8695bf410aa7510e5fb6e Mon Sep 17 00:00:00 2001
>From: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
>Date: Sat, 12 Jan 2019 20:09:23 +0100
>Subject: [PATCH] radv: Set partial_vs_wave even for parts without distributed
> tess.
>
>Distributed tessellation for radv is only set for 4-SE parts. Also,
>looking at -pro we need to enable it with tess disabeld too.
>---
> src/amd/vulkan/radv_pipeline.c | 19 +++++++++++--------
> 1 file changed, 11 insertions(+), 8 deletions(-)
>
>diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c
>index be374c9014d..5f40bd85c2e 100644
>--- a/src/amd/vulkan/radv_pipeline.c
>+++ b/src/amd/vulkan/radv_pipeline.c
>@@ -3429,14 +3429,6 @@ radv_compute_ia_multi_vgt_param_helpers(struct radv_pipeline *pipeline,
> 			if (radv_pipeline_has_gs(pipeline)) {
> 				if (device->physical_device->rad_info.chip_class <= VI)
> 					ia_multi_vgt_param.partial_es_wave = true;
>-
>-				if (device->physical_device->rad_info.family == CHIP_TONGA ||
>-				    device->physical_device->rad_info.family == CHIP_FIJI ||
>-				    device->physical_device->rad_info.family == CHIP_POLARIS10 ||
>-				    device->physical_device->rad_info.family == CHIP_POLARIS11 ||
>-				    device->physical_device->rad_info.family == CHIP_POLARIS12 ||
>-				    device->physical_device->rad_info.family == CHIP_VEGAM)
>-					ia_multi_vgt_param.partial_vs_wave = true;
> 			} else {
> 				ia_multi_vgt_param.partial_vs_wave = true;
> 			}
>@@ -3454,6 +3446,17 @@ radv_compute_ia_multi_vgt_param_helpers(struct radv_pipeline *pipeline,
> 		ia_multi_vgt_param.partial_vs_wave = true;
> 	}
> 
>+	if (radv_pipeline_has_gs(pipeline)) {
>+		if (device->physical_device->rad_info.family == CHIP_TONGA ||
>+		    device->physical_device->rad_info.family == CHIP_FIJI ||
>+		    device->physical_device->rad_info.family == CHIP_POLARIS10 ||
>+		    device->physical_device->rad_info.family == CHIP_POLARIS11 ||
>+		    device->physical_device->rad_info.family == CHIP_POLARIS12 ||
>+	            device->physical_device->rad_info.family == CHIP_VEGAM) {
>+			ia_multi_vgt_param.partial_vs_wave = true;
>+		}
>+	}
>+
> 	ia_multi_vgt_param.base =
> 		S_028AA8_PRIMGROUP_SIZE(ia_multi_vgt_param.primgroup_size - 1) |
> 		/* The following field was moved to VGT_SHADER_STAGES_EN in GFX9. */
>-- 
>2.20.1
>

Actions: View | Splinter Review

Attachments on bug 109242: 143024 | 143025 | 143033 | 143035 | 143082

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.