Attachment 144119 Details for Bug 110473 – VRR debugging output

[patch] VRR debugging output

amdgpu-VRR-debugging.diff (text/plain), 2.49 KB, created by Michel Dänzer on 2019-04-30 15:10:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Michel Dänzer

Created: 2019-04-30 15:10:39 UTC

Size: 2.49 KB

patch

obsolete

>diff --git a/src/amdgpu_kms.c b/src/amdgpu_kms.c
>index 74d5806c8..980a2eea7 100644
>--- a/src/amdgpu_kms.c
>+++ b/src/amdgpu_kms.c
>@@ -108,8 +108,12 @@ amdgpu_vrr_property_update(WindowPtr window, Bool variable_refresh)
> 	get_window_priv(window)->variable_refresh = variable_refresh;
> 
> 	if (info->flip_window == window &&
>-	    info->drmmode.present_flipping)
>+	    info->drmmode.present_flipping) {
>+		xf86DrvMsg(scrn->scrnIndex, X_INFO,
>+			   "%sabling VRR for flipping window %p\n",
>+			   variable_refresh ? "En" : "Dis", window);
> 		amdgpu_present_set_screen_vrr(scrn, variable_refresh);
>+	}
> }
> 
> /* Wrapper for xserver/dix/property.c:ProcChangeProperty */
>@@ -141,6 +145,8 @@ amdgpu_change_property(ClientPtr client)
> 	    AMDGPUPreInit_KMS && stuff->format == 32 && stuff->nUnits == 1) {
> 		uint32_t *value = (uint32_t*)(stuff + 1);
> 
>+		xf86DrvMsg(xf86ScreenToScrn(window->drawable.pScreen)->scrnIndex,
>+			   X_INFO, "Updating VRR property for window %p\n", window);
> 		amdgpu_vrr_property_update(window, *value != 0);
> 	}
> 
>@@ -173,8 +179,11 @@ amdgpu_delete_property(ClientPtr client)
> 
> 	if (stuff->property == amdgpu_vrr_atom &&
> 	    xf86ScreenToScrn(window->drawable.pScreen)->PreInit ==
>-	    AMDGPUPreInit_KMS)
>+	    AMDGPUPreInit_KMS) {
>+		xf86DrvMsg(xf86ScreenToScrn(window->drawable.pScreen)->scrnIndex,
>+			   X_INFO, "Deleting VRR property for window %p\n", window);
> 		amdgpu_vrr_property_update(window, FALSE);
>+	}
> 
> 	return ret;
> }
>diff --git a/src/amdgpu_present.c b/src/amdgpu_present.c
>index fdedd3266..49266b543 100644
>--- a/src/amdgpu_present.c
>+++ b/src/amdgpu_present.c
>@@ -301,6 +301,11 @@ amdgpu_present_check_flip(RRCrtcPtr crtc, WindowPtr window, PixmapPtr pixmap,
> 	if (num_crtcs_on == 0)
> 		return FALSE;
> 
>+	if (info->flip_window != window) {
>+		xf86DrvMsg(scrn->scrnIndex, X_INFO,
>+			   "Flipping window is %p now, was %p before\n",
>+			   window, info->flip_window);
>+	}
> 	info->flip_window = window;
> 
> 	return TRUE;
>diff --git a/src/drmmode_display.c b/src/drmmode_display.c
>index c410d0b97..edba38463 100644
>--- a/src/drmmode_display.c
>+++ b/src/drmmode_display.c
>@@ -327,8 +327,12 @@ void drmmode_crtc_set_vrr(xf86CrtcPtr crtc, Bool enabled)
> 				     drmmode_crtc->mode_crtc->crtc_id,
> 				     DRM_MODE_OBJECT_CRTC,
> 				     drmmode->vrr_prop_id,
>-				     enabled) == 0)
>+				     enabled) == 0) {
>+		xf86DrvMsg(pScrn->scrnIndex, X_INFO,
>+			   "%sabled VRR for CRTC %d\n", enabled ? "En" : "Dis",
>+			   drmmode_crtc->mode_crtc->crtc_id);
> 		drmmode_crtc->vrr_enabled = enabled;
>+	}
> }
> 
> static void

Actions: View | Splinter Review

Attachments on bug 110473: 144049 | 144050 | 144119 | 144141 | 144280 | 144718

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.