Attachment 144344 Details for Bug 110660 – force scaler usage for any non-natively-sized mode

[patch] force scaler usage for any non-natively-sized mode

0001-drm-nouveau-nv50-force-scaler-for-any-different-size.patch (text/plain), 1.64 KB, created by Ilia Mirkin on 2019-05-25 18:54:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ilia Mirkin

Created: 2019-05-25 18:54:29 UTC

Size: 1.64 KB

patch

obsolete

>From 34e528fa95676cc43e207fc1afbadf2b14e7feb0 Mon Sep 17 00:00:00 2001
>From: Ilia Mirkin <imirkin@alum.mit.edu>
>Date: Sat, 25 May 2019 14:33:05 -0400
>Subject: [PATCH] drm/nouveau/nv50-: force scaler for any different-sized
> LVDS/eDP modes
>
>Higher layers tend to add a lot of modes not actually in the EDID, such
>as the standard DMT modes. Changing this would be extremely intrusive to
>everyone, so just force the scaler more often. There are no practical
>cases we're aware of where a LVDS/eDP panel has multiple resolutions
>exposed, and i915 already does it this way.
>
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110660
>Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
>---
> drivers/gpu/drm/nouveau/dispnv50/disp.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/dispnv50/disp.c
>index 4b1650f51955..266d9d174b12 100644
>--- a/drivers/gpu/drm/nouveau/dispnv50/disp.c
>+++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c
>@@ -322,8 +322,13 @@ nv50_outp_atomic_check_view(struct drm_encoder *encoder,
> 		switch (connector->connector_type) {
> 		case DRM_MODE_CONNECTOR_LVDS:
> 		case DRM_MODE_CONNECTOR_eDP:
>-			/* Force use of scaler for non-EDID modes. */
>-			if (adjusted_mode->type & DRM_MODE_TYPE_DRIVER)
>+			/* Don't force scaler for EDID modes with
>+			 * same size as the native one (e.g. different
>+			 * refresh rate)
>+			 */
>+			if (adjusted_mode->hdisplay == native_mode->hdisplay &&
>+			    adjusted_mode->vdisplay == native_mode->vdisplay &&
>+			    adjusted_mode->type & DRM_MODE_TYPE_DRIVER)
> 				break;
> 			mode = native_mode;
> 			asyc->scaler.full = true;
>-- 
>2.21.0
>

Actions: View | Splinter Review

Attachments on bug 110660: 144215 | 144216 | 144217 | 144218 | 144220 | 144240 | 144241 | 144344 | 144346 | 144370 | 144371 | 144372 | 144373 | 146055

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.