Attachment 144354 Details for Bug 110659 – 0001-drm-amd-display-Allow-fast-updates-again-for-swappin.patch

[patch] 0001-drm-amd-display-Allow-fast-updates-again-for-swappin.patch

0001-drm-amd-display-Allow-fast-updates-again-for-swappin.patch (text/plain), 1.70 KB, created by Nicholas Kazlauskas on 2019-05-27 18:07:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nicholas Kazlauskas

Created: 2019-05-27 18:07:37 UTC

Size: 1.70 KB

patch

obsolete

>From fe0ae1a7694996aa0cc24b021f5b5d6b47051e29 Mon Sep 17 00:00:00 2001
>From: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
>Date: Mon, 27 May 2019 14:01:48 -0400
>Subject: [PATCH] drm/amd/display: Allow fast updates again for swapping cursor
> buffers
>
>[Why]
>There was a bug caused by incorrect refcounting and pin/unpin for
>plane framebuffers if they went through the atomic update path that
>has now been resolved.
>
>Cursor updates can cause jiterring to occur if they're waiting for
>vblank or page flip to be signaled so we want these to go through the
>fast path as often as possible.
>
>[How]
>Allow cursor framebuffer changes in the fast path.
>
>Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
>---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
>diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>index 57359037ed7c..3bdeba8c55e5 100644
>--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>@@ -4288,20 +4288,10 @@ static int dm_plane_atomic_check(struct drm_plane *plane,
> static int dm_plane_atomic_async_check(struct drm_plane *plane,
> 				       struct drm_plane_state *new_plane_state)
> {
>-	struct drm_plane_state *old_plane_state =
>-		drm_atomic_get_old_plane_state(new_plane_state->state, plane);
>-
> 	/* Only support async updates on cursor planes. */
> 	if (plane->type != DRM_PLANE_TYPE_CURSOR)
> 		return -EINVAL;
> 
>-	/*
>-	 * DRM calls prepare_fb and cleanup_fb on new_plane_state for
>-	 * async commits so don't allow fb changes.
>-	 */
>-	if (old_plane_state->fb != new_plane_state->fb)
>-		return -EINVAL;
>-
> 	return 0;
> }
> 
>-- 
>2.17.1
>

Actions: View | Splinter Review

Attachments on bug 110659: 144213 | 144214 | 144354 | 145117 | 145118 | 145119 | 145137 | 145138 | 145139 | 145140 | 145152 | 145207 | 145208 | 145209 | 145222 | 145278 | 145280

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.