Attachment 144752 Details for Bug 108826 – Fix escape clock pll divisor init

[patch] Fix escape clock pll divisor init

0001-drm-i915-Fix-wrong-escape-clock-divisor-init-for-GLK.patch (text/plain), 1.43 KB, created by Stanislav Lisovskiy on 2019-07-10 14:17:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Stanislav Lisovskiy

Created: 2019-07-10 14:17:41 UTC

Size: 1.43 KB

patch

obsolete

>From d0abcad422044096c1808adf0109c42e02d8bb45 Mon Sep 17 00:00:00 2001
>From: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
>Date: Wed, 10 Jul 2019 17:03:32 +0300
>Subject: [PATCH] drm/i915: Fix wrong escape clock divisor init for GLK
>
>According to Bspec clock divisor registers in GeminiLake
>should be initialized by shifting 1(<<) to amount of correspondent
>divisor. While i915 was writing all this time that value as is.
>
>Surprisingly that it by accident worked, until we met some issues
>with Microtech Etab.
>
>Signed-off-by: Stanislav.Lisovskiy@intel.com
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108826
>---
> drivers/gpu/drm/i915/display/vlv_dsi_pll.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/display/vlv_dsi_pll.c b/drivers/gpu/drm/i915/display/vlv_dsi_pll.c
>index 99cc3e2e9c2c..f016a776a39e 100644
>--- a/drivers/gpu/drm/i915/display/vlv_dsi_pll.c
>+++ b/drivers/gpu/drm/i915/display/vlv_dsi_pll.c
>@@ -396,8 +396,8 @@ static void glk_dsi_program_esc_clock(struct drm_device *dev,
> 	else
> 		txesc2_div = 10;
> 
>-	I915_WRITE(MIPIO_TXESC_CLK_DIV1, txesc1_div & GLK_TX_ESC_CLK_DIV1_MASK);
>-	I915_WRITE(MIPIO_TXESC_CLK_DIV2, txesc2_div & GLK_TX_ESC_CLK_DIV2_MASK);
>+	I915_WRITE(MIPIO_TXESC_CLK_DIV1, (1 << (txesc1_div - 1)) & GLK_TX_ESC_CLK_DIV1_MASK);
>+	I915_WRITE(MIPIO_TXESC_CLK_DIV2, (1 << (txesc2_div - 1)) & GLK_TX_ESC_CLK_DIV2_MASK);
> }
> 
> /* Program BXT Mipi clocks and dividers */
>-- 
>2.17.1
>

Actions: View | Splinter Review

Attachments on bug 108826: 142557 | 142580 | 142638 | 142639 | 143247 | 143248 | 143262 | 143270 | 143387 | 143388 | 143389 | 143390 | 143391 | 143589 | 143590 | 143591 | 143592 | 143866 | 143867 | 143868 | 143869 | 144350 | 144357 | 144378 | 144392 | 144393 | 144394 | 144395 | 144615 | 144752

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.