Attachment 144834 Details for Bug 109267 – [PATCH] x86/sysfb_efi: Add quirks for some devices with swapped width and height

[patch] [PATCH] x86/sysfb_efi: Add quirks for some devices with swapped width and height

0001-x86-sysfb_efi-Add-quirks-for-some-devices-with-swapp.patch (text/plain), 2.94 KB, created by Hans de Goede on 2019-07-21 15:28:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Hans de Goede

Created: 2019-07-21 15:28:19 UTC

Size: 2.94 KB

patch

obsolete

>From 109c58a9d3b4f2b673366c7eb285d4cccada3fbc Mon Sep 17 00:00:00 2001
>From: Hans de Goede <hdegoede@redhat.com>
>Date: Thu, 18 Jul 2019 14:11:55 +0200
>Subject: [PATCH] x86/sysfb_efi: Add quirks for some devices with swapped width
> and height
>
>Some Lenovo 2-in-1s with a detachable keyboard have a portrait screen
>but advertise a landscape resolution and pitch, resulting in a messed
>up display if we try to show anything on the efifb (because of the wrong
>pitch).
>
>This commit fixes this by adding a new DMI match table for devices which
>need to have their width and height swapped.
>
>At first I tried to use the existing table for overriding some of the
>efifb parameters, but some of the affected devices have variants with
>different LCD resolutions which will not work with hardcoded override
>values.
>
>BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1730783
>Cc: stable@vger.kernel.org
>Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>---
> arch/x86/kernel/sysfb_efi.c | 45 +++++++++++++++++++++++++++++++++++++
> 1 file changed, 45 insertions(+)
>
>diff --git a/arch/x86/kernel/sysfb_efi.c b/arch/x86/kernel/sysfb_efi.c
>index 8eb67a670b10..80d5b6720a87 100644
>--- a/arch/x86/kernel/sysfb_efi.c
>+++ b/arch/x86/kernel/sysfb_efi.c
>@@ -230,9 +230,54 @@ static const struct dmi_system_id efifb_dmi_system_table[] __initconst = {
> 	{},
> };
> 
>+/*
>+ * Some devices have a portrait LCD but advertise a landscape resolution (and
>+ * pitch). We simply swap width and height for these devices so that we can
>+ * correctly deal with some of them coming with multiple resolutions.
>+ */
>+static const struct dmi_system_id efifb_dmi_swap_width_height[] __initconst = {
>+	{
>+		/*
>+		 * Lenovo MIIX310-10ICR, only some batches have the troublesome
>+		 * 800x1280 portrait screen. Luckily the portrait version has
>+		 * its own BIOS version, so we match on that.
>+		 */
>+		.matches = {
>+			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>+			DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "MIIX 310-10ICR"),
>+			DMI_EXACT_MATCH(DMI_BIOS_VERSION, "1HCN44WW"),
>+		},
>+	},
>+	{
>+		/* Lenovo MIIX 320-10ICR with 800x1280 portrait screen */
>+		.matches = {
>+			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>+			DMI_EXACT_MATCH(DMI_PRODUCT_VERSION,
>+					"Lenovo MIIX 320-10ICR"),
>+		},
>+	},
>+	{
>+		/* Lenovo D330 with 800x1280 or 1200x1920 portrait screen */
>+		.matches = {
>+			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>+			DMI_EXACT_MATCH(DMI_PRODUCT_VERSION,
>+					"Lenovo ideapad D330-10IGM"),
>+		},
>+	},
>+	{},
>+};
>+
> __init void sysfb_apply_efi_quirks(void)
> {
> 	if (screen_info.orig_video_isVGA != VIDEO_TYPE_EFI ||
> 	    !(screen_info.capabilities & VIDEO_CAPABILITY_SKIP_QUIRKS))
> 		dmi_check_system(efifb_dmi_system_table);
>+
>+	if (screen_info.orig_video_isVGA == VIDEO_TYPE_EFI &&
>+	    dmi_check_system(efifb_dmi_swap_width_height)) {
>+		u16 temp = screen_info.lfb_width;
>+		screen_info.lfb_width = screen_info.lfb_height;
>+		screen_info.lfb_height = temp;
>+		screen_info.lfb_linelength = 4 * screen_info.lfb_width;
>+	}
> }
>-- 
>2.21.0
>

Actions: View | Splinter Review

Attachments on bug 109267: 143051 | 143114 | 143593 | 143628 | 143646 | 143647 | 143648 | 143649 | 143670 | 144039 | 144040 | 144041 | 144043 | 144045 | 144131 | 144151 | 144208 | 144834

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.