Attachment 145157 Details for Bug 110865 – fix DC code

[patch] fix DC code

0003-drm-amd-display-update-bw_calcs-to-take-pipe-sync-in.patch (text/plain), 2.18 KB, created by Alex Deucher on 2019-08-26 03:00:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Deucher

Created: 2019-08-26 03:00:16 UTC

Size: 2.18 KB

patch

obsolete

>From 62e5a6a86f85c673be61536b9c5ce9279d32a72e Mon Sep 17 00:00:00 2001
>From: Alex Deucher <alexander.deucher@amd.com>
>Date: Thu, 8 Aug 2019 09:03:46 -0500
>Subject: [PATCH 3/4] drm/amd/display: update bw_calcs to take pipe sync into
> account (v3)
>
>Properly set all_displays_in_sync so that when the data is
>propagated to powerplay, it's set properly and we can enable
>mclk switching when all monitors are in sync.
>
>v2: fix logic, clean up
>v3: check for blending chains, simplify logic
>
>Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
>---
> .../gpu/drm/amd/display/dc/calcs/dce_calcs.c  | 30 +++++++++++++++++--
> 1 file changed, 28 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c b/drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c
>index 9f12e21f8b9b..eca681d9d7f5 100644
>--- a/drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c
>+++ b/drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c
>@@ -25,6 +25,7 @@
> 
> #include <linux/slab.h>
> 
>+#include "resource.h"
> #include "dm_services.h"
> #include "dce_calcs.h"
> #include "dc.h"
>@@ -2977,6 +2978,32 @@ static void populate_initial_data(
> 	data->number_of_displays = num_displays;
> }
> 
>+static bool all_displays_in_sync(const struct pipe_ctx pipe[],
>+				 int pipe_count)
>+{
>+	const struct pipe_ctx *active_pipes[MAX_PIPES];
>+	int i, num_active_pipes = 0;
>+
>+	for (i = 0; i < pipe_count; i++) {
>+		if (!pipe[i].stream || pipe[i].top_pipe)
>+			continue;
>+
>+		active_pipes[num_active_pipes++] = &pipe[i];
>+	}
>+
>+	if (!num_active_pipes)
>+		return false;
>+
>+	for (i = 1; i < num_active_pipes; ++i) {
>+		if (!resource_are_streams_timing_synchronizable(
>+			    active_pipes[0]->stream, active_pipes[i]->stream)) {
>+			return false;
>+		}
>+	}
>+
>+	return true;
>+}
>+
> /**
>  * Return:
>  *	true -	Display(s) configuration supported.
>@@ -2998,8 +3025,7 @@ bool bw_calcs(struct dc_context *ctx,
> 
> 	populate_initial_data(pipe, pipe_count, data);
> 
>-	/*TODO: this should be taken out calcs output and assigned during timing sync for pplib use*/
>-	calcs_output->all_displays_in_sync = false;
>+	calcs_output->all_displays_in_sync = all_displays_in_sync(pipe, pipe_count);
> 
> 	if (data->number_of_displays != 0) {
> 		uint8_t yclk_lvl, sclk_lvl;
>-- 
>2.20.1
>

Actions: View | Splinter Review

Attachments on bug 110865: 144485 | 144978 | 144983 | 145136 | 145157 | 145180

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.