Attachment 145216 Details for Bug 111507 – Experimental patch to reveal if we skip encoder pre_enable

[patch] Experimental patch to reveal if we skip encoder pre_enable

v1-0001-Show-message-if-encoder-pre_enable-is-skipped-bec.patch (text/plain), 1.08 KB, created by Stanislav Lisovskiy on 2019-08-30 07:49:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Stanislav Lisovskiy

Created: 2019-08-30 07:49:27 UTC

Size: 1.08 KB

patch

obsolete

>From 5e00d9f206f62e2e722961bf51bc537971d97f53 Mon Sep 17 00:00:00 2001
>From: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
>Date: Fri, 30 Aug 2019 10:38:26 +0300
>Subject: [PATCH v1] Show message if encoder->pre_enable is skipped, because of
> different crtcs.
>
>---
> drivers/gpu/drm/i915/display/intel_display.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
>index f7fc2d25e7c2..5df3e7a505ba 100644
>--- a/drivers/gpu/drm/i915/display/intel_display.c
>+++ b/drivers/gpu/drm/i915/display/intel_display.c
>@@ -6182,8 +6182,11 @@ static void intel_encoders_pre_enable(struct intel_crtc *crtc,
> 		struct intel_encoder *encoder =
> 			to_intel_encoder(conn_state->best_encoder);
> 
>-		if (conn_state->crtc != &crtc->base)
>+		if (conn_state->crtc != &crtc->base) {
>+			DRM_DEBUG_KMS("Skipping encoder pre_enable, because crtc %p != base %p\n",
>+				conn_state->crtc, &crtc->base);
> 			continue;
>+		}
> 
> 		if (encoder->pre_enable)
> 			encoder->pre_enable(encoder, crtc_state, conn_state);
>-- 
>2.17.1
>

Actions: View | Splinter Review

Attachments on bug 111507: 145214 | 145216 | 145220 | 145234

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.