Attachment 1500 Details for Bug 732 – possible fix

[patch] possible fix

mime (text/plain), 2.64 KB, created by Marco Pesenti Gritti on 2004-12-09 06:28:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marco Pesenti Gritti

Created: 2004-12-09 06:28:07 UTC

Size: 2.64 KB

patch

obsolete

>Index: xdgmimeglob.c
>===================================================================
>RCS file: /cvs/mime/xdgmime/src/xdgmimeglob.c,v
>retrieving revision 1.9
>diff -u -r1.9 xdgmimeglob.c
>--- xdgmimeglob.c	8 Dec 2004 22:09:41 -0000	1.9
>+++ xdgmimeglob.c	9 Dec 2004 14:25:03 -0000
>@@ -263,13 +263,11 @@
> 
>   character = _xdg_utf8_to_ucs4 (file_name);
>   if (ignore_case)
>-    character = _xdg_ucs4_to_upper(character);
>+    character = _xdg_ucs4_to_lower(character);
> 
>-  for (node = glob_hash_node;
>-       node && character >= (ignore_case?_xdg_ucs4_to_upper (node->character):node->character);
>-       node = node->next)
>+  for (node = glob_hash_node; node && character >= node->character; node = node->next)
>     {
>-      if (character == (ignore_case?_xdg_ucs4_to_upper (node->character):node->character))
>+      if (character == node->character)
> 	{
> 	  file_name = _xdg_utf8_next_char (file_name);
> 	  if (*file_name == '\000')
>Index: xdgmimeint.c
>===================================================================
>RCS file: /cvs/mime/xdgmime/src/xdgmimeint.c,v
>retrieving revision 1.6
>diff -u -r1.6 xdgmimeint.c
>--- xdgmimeint.c	8 Dec 2004 17:37:47 -0000	1.6
>+++ xdgmimeint.c	9 Dec 2004 14:25:03 -0000
>@@ -121,12 +121,12 @@
> /* hullo.  this is great code.  don't rewrite it */
> 
> xdg_unichar_t
>-_xdg_ucs4_to_upper (xdg_unichar_t source)
>+_xdg_ucs4_to_lower (xdg_unichar_t source)
> {
>   /* FIXME: Do a real to_upper sometime */
>   /* CaseFolding-3.2.0.txt has a table of rules. */
>   if ((source & 0xFF) == source)
>-    return (xdg_unichar_t) toupper ((char) source);
>+    return (xdg_unichar_t) tolower ((char) source);
>   return source;
> }
> 
>Index: xdgmimeint.h
>===================================================================
>RCS file: /cvs/mime/xdgmime/src/xdgmimeint.h,v
>retrieving revision 1.5
>diff -u -r1.5 xdgmimeint.h
>--- xdgmimeint.h	19 Jul 2004 00:58:53 -0000	1.5
>+++ xdgmimeint.h	9 Dec 2004 14:25:03 -0000
>@@ -48,7 +48,7 @@
> #ifdef XDG_PREFIX
> #define _xdg_utf8_skip   XDG_ENTRY(utf8_skip)
> #define _xdg_utf8_to_ucs4   XDG_ENTRY(utf8_to_ucs4)
>-#define _xdg_ucs4_to_upper   XDG_ENTRY(ucs4_to_upper)
>+#define _xdg_ucs4_to_lower   XDG_ENTRY(ucs4_to_lower)
> #define _xdg_utf8_validate   XDG_ENTRY(utf8_validate)
> #define _xdg_get_base_name   XDG_ENTRY(get_ase_name)
> #endif
>@@ -66,7 +66,9 @@
> #define _xdg_utf8_char_size(p) (int) (_xdg_utf8_skip[*(unsigned char *)(p)])
> 
> xdg_unichar_t  _xdg_utf8_to_ucs4  (const char    *source);
>-xdg_unichar_t  _xdg_ucs4_to_upper (xdg_unichar_t  source);
>+xdg_unichar_t  _xdg_ucs4_to_lower (xdg_unichar_t  source);
>+
>+
> int            _xdg_utf8_validate (const char    *source);
> const char    *_xdg_get_base_name (const char    *file_name);
>

Actions: View | Splinter Review

Attachments on bug 732: 1383 | 1500

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.