Attachment 15294 Details for Bug 15097 – Report damage for GLX_MESA_copy_sub_buffer

[patch] Report damage for GLX_MESA_copy_sub_buffer

mesa-report-damage.diff (text/plain), 2.49 KB, created by Michel Dänzer on 2008-03-19 05:44:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Michel Dänzer

Created: 2008-03-19 05:44:23 UTC

Size: 2.49 KB

patch

obsolete

>diff --git a/src/mesa/drivers/dri/common/dri_util.c b/src/mesa/drivers/dri/common/dri_util.c
>index 1f5d652..d7b3683 100644
>--- a/src/mesa/drivers/dri/common/dri_util.c
>+++ b/src/mesa/drivers/dri/common/dri_util.c
>@@ -430,6 +430,30 @@ __driParseEvents(__DRIcontextPrivate *pcp, __DRIdrawablePrivate *pdp)
> /*****************************************************************/
> /*@{*/
> 
>+static void driReportDamage(__DRIdrawable *drawable, int x, int y, int w, int h)
>+{
>+    __DRIdrawablePrivate *dPriv = drawable->private;
>+    __DRIscreenPrivate *psp = dPriv->driScreenPriv;
>+    drm_clip_rect_t rect;
>+
>+    /* Check that we actually have the new damage report method */
>+    if (psp->damage == NULL)
>+	return;
>+
>+    /* Assume it's affecting the whole drawable for now */
>+    rect.x1 = x;
>+    rect.y1 = y;
>+    rect.x2 = x + w;
>+    rect.y2 = y + h;
>+
>+    /* Report the damage.  Currently, all our drivers draw directly to the
>+     * front buffer, so we report the damage there rather than to the backing
>+     * store (if any).
>+     */
>+    (*psp->damage->reportDamage)(dPriv->pdraw,
>+				 dPriv->x, dPriv->y, &rect, 1, GL_TRUE);
>+}
>+
> /**
>  * Swap buffers.
>  *
>@@ -443,30 +467,13 @@ __driParseEvents(__DRIcontextPrivate *pcp, __DRIdrawablePrivate *pdp)
> static void driSwapBuffers(__DRIdrawable *drawable)
> {
>     __DRIdrawablePrivate *dPriv = drawable->private;
>-    __DRIscreenPrivate *psp = dPriv->driScreenPriv;
>-    drm_clip_rect_t rect;
> 
>     if (!dPriv->numClipRects)
>         return;
> 
>     dPriv->swapBuffers(dPriv);
> 
>-    /* Check that we actually have the new damage report method */
>-    if (psp->damage == NULL)
>-	return;
>-
>-    /* Assume it's affecting the whole drawable for now */
>-    rect.x1 = 0;
>-    rect.y1 = 0;
>-    rect.x2 = rect.x1 + dPriv->w;
>-    rect.y2 = rect.y1 + dPriv->h;
>-
>-    /* Report the damage.  Currently, all our drivers draw directly to the
>-     * front buffer, so we report the damage there rather than to the backing
>-     * store (if any).
>-     */
>-    (*psp->damage->reportDamage)(dPriv->pdraw,
>-				 dPriv->x, dPriv->y, &rect, 1, GL_TRUE);
>+    driReportDamage(drawable, 0, 0, dPriv->w, dPriv->h);
> }
> 
> static int driDrawableGetMSC( __DRIscreen *screen, __DRIdrawable *drawable,
>@@ -515,6 +522,7 @@ static void driCopySubBuffer(__DRIdrawable *drawable,
> {
>     __DRIdrawablePrivate *dPriv = drawable->private;
>     dPriv->driScreenPriv->DriverAPI.CopySubBuffer(dPriv, x, y, w, h);
>+    driReportDamage(drawable, x, y, w, h);
> }
> 
> const __DRIcopySubBufferExtension driCopySubBufferExtension = {

Actions: View | Splinter Review

Attachments on bug 15097: 15294

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.