Attachment 15591 Details for Bug 15295 – fixes for format string vulnerabilities

[patch] fixes for format string vulnerabilities

10_format-string-security.patch (text/plain), 2.88 KB, created by Kees Cook on 2008-03-31 16:39:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kees Cook

Created: 2008-03-31 16:39:38 UTC

Size: 2.88 KB

patch

obsolete

>diff -Nur -x '*.orig' -x '*~' policykit-0.7/configure.in policykit-0.7.new/configure.in
>--- policykit-0.7/configure.in	2008-03-31 16:25:56.000000000 -0700
>+++ policykit-0.7.new/configure.in	2008-03-31 16:26:23.000000000 -0700
>@@ -114,6 +114,16 @@
>   *) CFLAGS="$CFLAGS -Wsign-compare" ;;
>   esac
> 
>+  case " $CFLAGS " in
>+  *[\ \	]-Wformat[\ \	]*) ;;
>+  *) CFLAGS="$CFLAGS -Wformat" ;;
>+  esac
>+
>+  case " $CFLAGS " in
>+  *[\ \	]-Wformat-security[\ \	]*) ;;
>+  *) CFLAGS="$CFLAGS -Wformat-security" ;;
>+  esac
>+
>   if test "x$enable_ansi" = "xyes"; then
>     case " $CFLAGS " in
>     *[\ \	]-ansi[\ \	]*) ;;
>diff -Nur -x '*.orig' -x '*~' policykit-0.7/configure policykit-0.7.new/configure
>--- policykit-0.7/configure	2008-03-31 16:25:56.000000000 -0700
>+++ policykit-0.7.new/configure	2008-03-31 16:26:22.000000000 -0700
>@@ -21987,6 +21987,16 @@
>   *) CFLAGS="$CFLAGS -Wsign-compare" ;;
>   esac
> 
>+  case " $CFLAGS " in
>+  *[\ \	]-Wformat[\ \	]*) ;;
>+  *) CFLAGS="$CFLAGS -Wformat" ;;
>+  esac
>+
>+  case " $CFLAGS " in
>+  *[\ \	]-Wformat-security[\ \	]*) ;;
>+  *) CFLAGS="$CFLAGS -Wformat-security" ;;
>+  esac
>+
>   if test "x$enable_ansi" = "xyes"; then
>     case " $CFLAGS " in
>     *[\ \	]-ansi[\ \	]*) ;;
>diff -Nur -x '*.orig' -x '*~' policykit-0.7/src/polkit/polkit-policy-cache.c policykit-0.7.new/src/polkit/polkit-policy-cache.c
>--- policykit-0.7/src/polkit/polkit-policy-cache.c	2008-03-31 16:26:18.000000000 -0700
>+++ policykit-0.7.new/src/polkit/polkit-policy-cache.c	2008-03-31 16:28:07.000000000 -0700
>@@ -147,7 +147,7 @@
>                  * not figure it out */
>                 if (d->d_type == DT_UNKNOWN) {
>                         if (stat(path, &st) != 0) {
>-                                polkit_error_set_error (error, POLKIT_ERROR_POLICY_FILE_INVALID, path);
>+                                polkit_error_set_error (error, POLKIT_ERROR_POLICY_FILE_INVALID, "%s", path);
>                                 goto out;
>                         }
>                         if (!S_ISREG(st.st_mode))
>diff -Nur -x '*.orig' -x '*~' policykit-0.7/src/polkit-grant/polkit-grant-helper.c policykit-0.7.new/src/polkit-grant/polkit-grant-helper.c
>--- policykit-0.7/src/polkit-grant/polkit-grant-helper.c	2007-12-05 18:48:36.000000000 -0800
>+++ policykit-0.7.new/src/polkit-grant/polkit-grant-helper.c	2008-03-31 16:27:24.000000000 -0700
>@@ -228,7 +228,7 @@
>                 *empty_conversation = FALSE;
> 
>                 /* send to parent */
>-                fprintf (stdout, buf);
>+                fprintf (stdout, "%s", buf);
>                 fflush (stdout);
>                 
>                 /* read from parent */
>@@ -239,7 +239,7 @@
>                 fprintf (stderr, "received: '%s' from parent; sending to child\n", buf);
> #endif /* PGH_DEBUG */
>                 /* send to child */
>-                fprintf (child_stdin, buf);
>+                fprintf (child_stdin, "%s", buf);
>                 fflush (child_stdin);
>         }
>

Actions: View | Splinter Review

Attachments on bug 15295: 15591 | 15671

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.