Attachment 16029 Details for Bug 15515 – PATCH: prefer glxvisuals with stencil buffer for default visuals

[patch] PATCH: prefer glxvisuals with stencil buffer for default visuals

xserver-1.5.0-stencilbits-in-glx-visuals.patch (text/plain), 1.64 KB, created by Hans de Goede on 2008-04-18 15:50:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Hans de Goede

Created: 2008-04-18 15:50:57 UTC

Size: 1.64 KB

patch

obsolete

>--- xorg-server-20080415/GL/glx/glxscreens.c~	2008-04-19 00:23:15.000000000 +0200
>+++ xorg-server-20080415/GL/glx/glxscreens.c	2008-04-19 00:25:53.000000000 +0200
>@@ -437,6 +437,7 @@ initGlxVisual(VisualPtr visual, __GLXcon
> typedef struct {
>     GLboolean doubleBuffer;
>     GLboolean depthBuffer;
>+    GLboolean stencilBuffer;
> } FBConfigTemplateRec, *FBConfigTemplatePtr;
> 
> static __GLXconfig *
>@@ -453,6 +454,8 @@ pickFBConfig(__GLXscreen *pGlxScreen, FB
> 	    continue;
> 	if ((config->depthBits > 0) != template->depthBuffer)
> 	    continue;
>+	if ((config->stencilBits > 0) != template->stencilBuffer)
>+	    continue;
> 
> 	return config;
>     }
>@@ -466,8 +469,9 @@ addMinimalSet(__GLXscreen *pGlxScreen)
>     __GLXconfig *config;
>     VisualPtr visuals;
>     int i, j;
>-    FBConfigTemplateRec best = { GL_TRUE, GL_TRUE };
>-    FBConfigTemplateRec minimal = { GL_FALSE, GL_FALSE };
>+    FBConfigTemplateRec best = { GL_TRUE, GL_TRUE, GL_TRUE };
>+    FBConfigTemplateRec good = { GL_TRUE, GL_TRUE, GL_FALSE };
>+    FBConfigTemplateRec minimal = { GL_FALSE, GL_FALSE, GL_FALSE };
> 
>     pGlxScreen->visuals = xcalloc(pGlxScreen->pScreen->numVisuals,
> 				  sizeof (__GLXconfig *));
>@@ -480,8 +484,11 @@ addMinimalSet(__GLXscreen *pGlxScreen)
>     for (i = 0, j = 0; i < pGlxScreen->pScreen->numVisuals; i++) {
> 	if (visuals[i].nplanes == 32)
> 	    config = pickFBConfig(pGlxScreen, &minimal, visuals[i].class);
>-	else
>+	else {
> 	    config = pickFBConfig(pGlxScreen, &best, visuals[i].class);
>+	    if (config == NULL)
>+		config = pickFBConfig(pGlxScreen, &good, visuals[i].class);
>+        }
> 	if (config == NULL)
> 	    config = pGlxScreen->fbconfigs;
> 	if (config == NULL)

Actions: View | Splinter Review

Attachments on bug 15515: 15923 | 16029

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.