Attachment 16708 Details for Bug 16067 – 0528-Correct-a-NULL-pointer-deference.patch

[patch] 0528-Correct-a-NULL-pointer-deference.patch

0528-Correct-a-NULL-pointer-deference.patch (text/plain), 1.05 KB, created by Paulo César Pereira de Andrade on 2008-05-23 10:32:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Paulo César Pereira de Andrade

Created: 2008-05-23 10:32:40 UTC

Size: 1.05 KB

patch

obsolete

>From 55188f7892d675b8be76ddbdf326968afe43a707 Mon Sep 17 00:00:00 2001
>From: Paulo Cesar Pereira de Andrade <pcpa@mandriva.com.br>
>Date: Fri, 23 May 2008 13:50:39 -0300
>Subject: [PATCH] Correct a NULL pointer deference
>
>  The problem happens if Monitor/Card combo doesn't provide EDID info,
>and the XFree86-VidModeExtension extension is used.
>---
> hw/xfree86/common/xf86VidMode.c |   10 +++++++---
> 1 files changed, 7 insertions(+), 3 deletions(-)
>
>diff --git a/hw/xfree86/common/xf86VidMode.c b/hw/xfree86/common/xf86VidMode.c
>index 16a4d82..64e6a37 100644
>--- a/hw/xfree86/common/xf86VidMode.c
>+++ b/hw/xfree86/common/xf86VidMode.c
>@@ -157,10 +157,14 @@ VidModeGetCurrentModeline(int scrnIndex, pointer *mode, int *dotClock)
> 	return FALSE;
> 
>     pScrn = xf86Screens[scrnIndex];
>-    *mode = (pointer)(pScrn->currentMode);
>-    *dotClock = pScrn->currentMode->Clock;
> 
>-    return TRUE;
>+    if (pScrn->currentMode) {
>+	*mode = (pointer)(pScrn->currentMode);
>+	*dotClock = pScrn->currentMode->Clock;
>+
>+	return TRUE;
>+    }
>+    return FALSE;
> }
> 
> _X_EXPORT int
>-- 
>1.5.4.3
>

Actions: View | Splinter Review

Attachments on bug 16067: 16708

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.