Attachment 16764 Details for Bug 16114 – new version that doesn't use-after-free in the error case

[patch] new version that doesn't use-after-free in the error case

dbus-glib-0.74-getall-wincaps-to-uscore.patch (text/plain), 1.28 KB, created by Dan Williams on 2008-05-27 06:43:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Dan Williams

Created: 2008-05-27 06:43:59 UTC

Size: 1.28 KB

patch

obsolete

>diff -up dbus-glib-0.74/dbus/dbus-gobject.c.getall-wincaps-to-uscore dbus-glib-0.74/dbus/dbus-gobject.c
>--- dbus-glib-0.74/dbus/dbus-gobject.c.getall-wincaps-to-uscore	2008-05-27 08:49:46.000000000 -0400
>+++ dbus-glib-0.74/dbus/dbus-gobject.c	2008-05-27 09:39:13.000000000 -0400
>@@ -775,6 +775,7 @@ get_all_object_properties (DBusConnectio
>   DBusMessageIter iter_dict_entry;
>   DBusMessageIter iter_dict_value;
>   const char *p;
>+  char *uscore_propname;
> 
>   ret = dbus_message_new_method_return (message);
>   if (ret == NULL)
>@@ -815,13 +816,18 @@ get_all_object_properties (DBusConnectio
>         p++;
>       p++;
> 
>-      pspec = g_object_class_find_property (G_OBJECT_GET_CLASS (object), prop_name);
>+      uscore_propname = _dbus_gutils_wincaps_to_uscore (prop_name);
>+
>+      pspec = g_object_class_find_property (G_OBJECT_GET_CLASS (object), uscore_propname);
>       if (pspec == NULL)
>         {
>-          g_warning ("introspection data references non-existing property %s", prop_name);
>+          g_warning ("introspection data references non-existing property %s", uscore_propname);
>+          g_free (uscore_propname);
>           continue;
>         }
> 
>+      g_free (uscore_propname);
>+
>       g_value_init (&value, pspec->value_type);
>       g_object_get_property (object, pspec->name, &value);
>

Actions: View | Splinter Review

Attachments on bug 16114: 16763 | 16764

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.