Attachment 17038 Details for Bug 16284 – Don't program DSPARB on old, single pipe chips

[patch] Don't program DSPARB on old, single pipe chips

i830-dsparb-fifo-size-fix-2.patch (text/plain), 1.29 KB, created by Jesse Barnes on 2008-06-10 15:14:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jesse Barnes

Created: 2008-06-10 15:14:47 UTC

Size: 1.29 KB

patch

obsolete

>diff --git a/src/i830_driver.c b/src/i830_driver.c
>index 091b5ca..8f77fb5 100644
>--- a/src/i830_driver.c
>+++ b/src/i830_driver.c
>@@ -1937,19 +1937,21 @@ i830_set_dsparb(ScrnInfoPtr pScrn)
>    i830WaitForVblank(pScrn);
> 
>    /* Fixup FIFO defaults:
>-    * we don't use plane C at all so we can allocate all but one of the 96
>-    * FIFO RAM entries equally between planes A and B.
>+    * we don't use plane C at all so we can allocate all but one of the
>+    * FIFO RAM entries equally between planes A and B (or just A for old
>+    * chipsets).
>     */
>-   if (IS_I9XX(pI830)) {
>-       if (IS_I965GM(pI830) || IS_IGD_GM(pI830))
>-	   OUTREG(DSPARB, (127 << DSPARB_CSTART_SHIFT) |
>-		  (64 << DSPARB_BSTART_SHIFT));
>-       else
>+
>+   /* Recent chips have 128x64B entries */
>+   if (IS_I965GM(pI830) || IS_IGD_GM(pI830))
>+           OUTREG(DSPARB, (127 << DSPARB_CSTART_SHIFT) |
>+                  (64 << DSPARB_BSTART_SHIFT));
>+   else if (IS_I9XX(pI830)) /* older 9xx chips have 96x64B entries */
> 	   OUTREG(DSPARB, (95 << DSPARB_CSTART_SHIFT) |
> 		  (48 << DSPARB_BSTART_SHIFT));
>-   } else {
>+   else if (IS_MOBILE(pI830)) /* previous mobile chips have 256x16B entries */
>        OUTREG(DSPARB, 254 << DSPARB_BEND_SHIFT | 128 << DSPARB_AEND_SHIFT);
>-   }
>+   /* leave even older chips alone */
> }
> 
> enum pipe {

Actions: View | Splinter Review

Attachments on bug 16284: 17018 | 17038

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.