Attachment 18677 Details for Bug 17433 – Fix signed vs. unsigned char* warnings in dbus-string-util.c

[patch] Fix signed vs. unsigned char* warnings in dbus-string-util.c

0005-Fix-signed-vs.-unsigned-char-warnings-in-dbus-strin.patch (text/plain), 1.55 KB, created by Peter McCurdy on 2008-09-04 10:55:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Peter McCurdy

Created: 2008-09-04 10:55:56 UTC

Size: 1.55 KB

patch

obsolete

>From 97b38f8ca4131b04d0bc838d6767e6058268d586 Mon Sep 17 00:00:00 2001
>From: Peter McCurdy <petermccurdy@alumni.uwaterloo.ca>
>Date: Mon, 1 Sep 2008 23:22:25 -0400
>Subject: [PATCH] Fix signed vs. unsigned char* warnings in dbus-string-util.c
>
>The test_hex_roundtrip() test function had no particular reason to take
>an unsigned char*, and there was no real reason for the test code to
>give it one.  Now they just deal with signed char*s.
>---
> dbus/dbus-string-util.c |   10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
>diff --git a/dbus/dbus-string-util.c b/dbus/dbus-string-util.c
>index aed9487..58e9e7e 100644
>--- a/dbus/dbus-string-util.c
>+++ b/dbus/dbus-string-util.c
>@@ -139,8 +139,8 @@ test_max_len (DBusString *str,
> }
> 
> static void
>-test_hex_roundtrip (const unsigned char *data,
>-                    int                  len)
>+test_hex_roundtrip (const char *data,
>+                    int         len)
> {
>   DBusString orig;
>   DBusString encoded;
>@@ -189,8 +189,8 @@ test_hex_roundtrip (const unsigned char *data,
>   _dbus_string_free (&decoded);  
> }
> 
>-typedef void (* TestRoundtripFunc) (const unsigned char *data,
>-                                    int                  len);
>+typedef void (* TestRoundtripFunc) (const char *data,
>+                                    int         len);
> static void
> test_roundtrips (TestRoundtripFunc func)
> {
>@@ -213,7 +213,7 @@ test_roundtrips (TestRoundtripFunc func)
>   (* func) ("1234", 5);
>   (* func) ("12345", 6);
>   {
>-    unsigned char buf[512];
>+    char buf[512];
>     int i;
>     
>     i = 0;
>-- 
>1.5.4.3
>

Actions: View | Splinter Review

Attachments on bug 17433: 18673 | 18674 | 18675 | 18676 | 18677

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.