Attachment 19013 Details for Bug 16520 – Fix random/white color overlays.

[patch] Fix random/white color overlays.

t_vertex.patch (text/plain), 1.35 KB, created by Guillaume Melquiond on 2008-09-19 08:36:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Guillaume Melquiond

Created: 2008-09-19 08:36:19 UTC

Size: 1.35 KB

patch

obsolete

>diff --git a/src/mesa/tnl/t_vertex_generic.c b/src/mesa/tnl/t_vertex_generic.c
>index 236a5be..c52da25 100644
>--- a/src/mesa/tnl/t_vertex_generic.c
>+++ b/src/mesa/tnl/t_vertex_generic.c
>@@ -107,7 +107,7 @@ static INLINE void insert_3f_viewport_2( const struct tnl_clipspace_attr *a, GLu
>    
>    out[0] = vp[0] * in[0] + vp[12];
>    out[1] = vp[5] * in[1] + vp[13];
>-   out[2] = vp[10] * in[2] + vp[14];
>+   out[2] = vp[14];
> }
> 
> static INLINE void insert_3f_viewport_1( const struct tnl_clipspace_attr *a, GLubyte *v,
>diff --git a/src/mesa/tnl/t_vertex_sse.c b/src/mesa/tnl/t_vertex_sse.c
>index f1c98fe..13e0fb3 100644
>--- a/src/mesa/tnl/t_vertex_sse.c
>+++ b/src/mesa/tnl/t_vertex_sse.c
>@@ -488,7 +488,7 @@ static GLboolean build_vertex_emit( struct x86_program *p )
> 	 {
> 	    get_src_ptr(p, srcECX, vtxESI, a);
> 	    emit_load(p, temp, 1, x86_deref(srcECX), a->inputsize);
>-	    sse_shufps(&p->func, temp, temp, SHUF(X,X,X,X));
>+	    sse_shufps(&p->func, temp, temp, SHUF(Y,Y,Y,X));
> 	    emit_pack_store_4ub(p, x86_make_disp(dest, -3), temp); /* overkill! */
> 	    update_src_ptr(p, srcECX, vtxESI, a);
> 	 }
>@@ -539,8 +539,8 @@ static GLboolean build_vertex_emit( struct x86_program *p )
> 	 }
> 	 else {
> 	    _mesa_printf("Can't emit 3ub\n");
>+	    return GL_FALSE;	/* add this later */
> 	 }
>-	 return GL_FALSE;	/* add this later */
> 	 break;
> 
>       case EMIT_4UB_4F_RGBA:

Actions: View | Splinter Review

Attachments on bug 16520: 17561 | 19013 | 19021 | 19022 | 19048

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.