Attachment 21441 Details for Bug 19219 – patch-3-Let_compiler_figure_out_CDECL

[patch] patch-3-Let_compiler_figure_out_CDECL

patch-3-Let_compiler_figure_out_CDECL (text/plain), 1.14 KB, created by Hib Eris on 2008-12-23 09:58:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Hib Eris

Created: 2008-12-23 09:58:45 UTC

Size: 1.14 KB

patch

obsolete

>commit 837b5bff78d35018f5259de50a1ddc5740b8104f
>Author: Hib Eris <hib@hiberis.nl>
>Date:   Mon Dec 22 21:31:59 2008 +0100
>
>    Let compiler figure out CDECL
>    
>    CDECL is a compiler specific macro to specify C calling convention.
>    
>    On Windows, some functions must be forced to use this calling convention.
>    To do this, you can use the macro CDECL, which is defined in windef.h.
>    
>    Poppler should not try to be smarter than the compiler and try to guess
>    the correct definition for CDECL. Instead it should rely on the
>    definitions in the windef.h file provided by the compiler.
>    
>    On Unix, specifying a calling convention is not nescessary, so CDECL can
>    be an empty definition.
>
>diff --git a/poppler/poppler-config.h.in b/poppler/poppler-config.h.in
>index c78d75f..32d0f63 100644
>--- a/poppler/poppler-config.h.in
>+++ b/poppler/poppler-config.h.in
>@@ -69,12 +69,8 @@
> // Win32 stuff
> //------------------------------------------------------------------------
> 
>-#ifdef CDECL
>-#undef CDECL
>-#endif
>-
>-#if defined(_MSC_VER) || defined(__BORLANDC__)
>-#define CDECL __cdecl
>+#ifdef WIN32
>+#include <windef.h>
> #else
> #define CDECL
> #endif

Actions: View | Splinter Review

Attachments on bug 19219: 21357 | 21358 | 21369 | 21441

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.