Attachment 22041 Details for Bug 19621 – fix FPE in libfb

[patch] fix FPE in libfb

0001-fix-FPE-when-initializing-screen.patch (text/plain), 1.15 KB, created by Kees Cook on 2009-01-16 14:03:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kees Cook

Created: 2009-01-16 14:03:09 UTC

Size: 1.15 KB

patch

obsolete

>From fe93dea684c520f7f92e4ee313d2c01e70d55469 Mon Sep 17 00:00:00 2001
>From: Kees Cook <kees.cook@canonical.com>
>Date: Fri, 16 Jan 2009 13:35:05 -0800
>Subject: [PATCH] fix FPE when initializing screen
>
>The radeon driver under strange situations when plugging/unplugging
>an external display can call fbScreenInit with 0 sizes, leading to
>an FPE.
>
>Ubuntu: https://bugs.launchpad.net/ubuntu/+source/xorg-server/+bug/317957
>
>Signed-off-by: Kees Cook <kees.cook@canonical.com>
>---
> mi/miscrinit.c |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/mi/miscrinit.c b/mi/miscrinit.c
>index 157a17f..8ac66fe 100644
>--- a/mi/miscrinit.c
>+++ b/mi/miscrinit.c
>@@ -219,8 +219,8 @@ miScreenInit(
> {
>     pScreen->width = xsize;
>     pScreen->height = ysize;
>-    pScreen->mmWidth = (xsize * 254 + dpix * 5) / (dpix * 10);
>-    pScreen->mmHeight = (ysize * 254 + dpiy * 5) / (dpiy * 10);
>+    pScreen->mmWidth = dpix ? (xsize * 254 + dpix * 5) / (dpix * 10) : 0;
>+    pScreen->mmHeight = dpiy ? (ysize * 254 + dpiy * 5) / (dpiy * 10) : 0;
>     pScreen->numDepths = numDepths;
>     pScreen->rootDepth = rootDepth;
>     pScreen->allowedDepths = depths;
>-- 
>1.6.0.4
>

Actions: View | Splinter Review

Attachments on bug 19621: 22041

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.