Attachment 22308 Details for Bug 19781 – patch to workaround insanity

[patch] patch to workaround insanity

yum-is-interesting.patch (text/plain), 998 bytes, created by Richard Hughes on 2009-01-28 08:12:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Richard Hughes

Created: 2009-01-28 08:12:00 UTC

Size: 998 bytes

patch

obsolete

>commit c145ca1396fb73c50c63177cfd668ee2806d9ed0
>Author: Richard Hughes <richard@hughsie.com>
>Date:   Wed Jan 28 16:09:37 2009 +0000
>
>    yum: try harder to get some useful text when yum passes us a structure in a message. Hopefully works around fd#19781
>
>diff --git a/backends/yum/yumBackend.py b/backends/yum/yumBackend.py
>index a73ad4f..e9c5233 100755
>--- a/backends/yum/yumBackend.py
>+++ b/backends/yum/yumBackend.py
>@@ -164,7 +164,15 @@ def _is_development_repo(repo):
> def _format_msgs(msgs):
>     if isinstance(msgs, basestring):
>         msgs = msgs.split('\n')
>-    text = ";".join(msgs)
>+
>+    # yum can pass us structures (!) in the message field
>+    try:
>+        text = ";".join(msgs)
>+    except exceptions.TypeError, e:
>+        text = str(msgs)
>+    except Exception, e:
>+        text = _format_str(traceback.format_exc())
>+
>     text = _truncate(text, 1024)
>     text = text.replace(";Please report this error in bugzilla", "")
>     text = text.replace("Missing Dependency: ", "")

Actions: View | Splinter Review

Attachments on bug 19781: 22308

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.