Attachment 24196 Details for Bug 20825 – Try to report current composite manager name

[patch] Try to report current composite manager name

0003-Try-to-report-current-composite-manager-name.patch (text/plain), 1.61 KB, created by Yann Droneaud on 2009-03-24 07:00:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Yann Droneaud

Created: 2009-03-24 07:00:13 UTC

Size: 1.61 KB

patch

obsolete

>From 180b31fbb39b0525707daf6de8cf02333f016254 Mon Sep 17 00:00:00 2001
>From: Yann Droneaud <ydroneaud@mandriva.com>
>Date: Tue, 24 Mar 2009 12:59:01 +0100
>Subject: [PATCH 3/3] Try to report current composite manager name
>
>Try to read NET_WM_CM_Sn owner's NET_WM_NAME (or WM_NAME) property,
>otherwise report it's window id.
>Remarks: metacity and kwin currently don't set a window name for
>NET_WM_CM_Sn owner, but xcompmgr and compiz do. This should be added
>to wm-spec.
>---
> xcompmgr.c |   28 ++++++++++++++++++++++++++--
> 1 files changed, 26 insertions(+), 2 deletions(-)
>
>diff --git a/xcompmgr.c b/xcompmgr.c
>index 938a37e..ea8fa7d 100644
>--- a/xcompmgr.c
>+++ b/xcompmgr.c
>@@ -1877,9 +1877,33 @@ register_cm (void)
>     snprintf (net_wm_cm, sizeof (net_wm_cm), "_NET_WM_CM_S%d", scr);
>     a = XInternAtom (dpy, net_wm_cm, False);
> 
>-    if (XGetSelectionOwner (dpy, a) != None)
>-    {
>-	fprintf (stderr, "Another composite manager is already running\n");
>+    w = XGetSelectionOwner (dpy, a);
>+    if (w != None)
>+    {
>+	XTextProperty tp;
>+	char **strs;
>+	int count;
>+	Atom winNameAtom = XInternAtom (dpy, "_NET_WM_NAME", False);
>+      
>+	if (!XGetTextProperty (dpy, w, &tp, winNameAtom) &&
>+	    !XGetTextProperty (dpy, w, &tp, XA_WM_NAME))
>+	{
>+		fprintf (stderr,
>+			 "Another composite manager is already running (0x%lx)\n",
>+			 (unsigned long) w);
>+		return False;
>+	}
>+	if (XmbTextPropertyToTextList (dpy, &tp, &strs, &count) == Success) 
>+	{
>+		fprintf (stderr, 
>+			 "Another composite manager is already running (%s)\n",
>+			 strs[0]);
>+	  
>+		XFreeStringList (strs);
>+	}
>+
>+	XFree (tp.value);
>+
> 	return False;
>     }
> 
>-- 
>1.6.0.2
>

Actions: View | Splinter Review

Attachments on bug 20825: 24195 | 24196

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.