Attachment 25616 Details for Bug 20951 – pfit debugging 2

[patch] pfit debugging 2

i830-pfit-debug-2.patch (text/plain), 2.49 KB, created by Jesse Barnes on 2009-05-07 15:34:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jesse Barnes

Created: 2009-05-07 15:34:25 UTC

Size: 2.49 KB

patch

obsolete

>diff --git a/src/i830_lvds.c b/src/i830_lvds.c
>index 064810f..8af4965 100644
>--- a/src/i830_lvds.c
>+++ b/src/i830_lvds.c
>@@ -672,6 +672,8 @@ i830_lvds_mode_fixup(xf86OutputPtr output, DisplayModePtr mode,
>     desired_ratio = (float)mode->HDisplay /
> 	(float)mode->VDisplay;
> 
>+    ErrorF("native ratio: %f, desired ratio: %f\n", panel_ratio, desired_ratio);
>+
>     /*
>      * Enable automatic panel scaling for non-native modes so that they fill
>      * the screen.  Should be enabled before the pipe is enabled, according to
>@@ -747,6 +749,10 @@ i830_lvds_mode_fixup(xf86OutputPtr output, DisplayModePtr mode,
> 	    if (panel_ratio > desired_ratio) { /* Pillar */
> 		unsigned long scaled_width = (float)mode->HDisplay * vert_scale;
> 
>+		ErrorF("pillarbox scaling\n");
>+
>+		ErrorF("scaled_width: %ld\n", scaled_width);
>+
> 		horiz_ratio = vert_ratio;
> 		pfit_control |= VERT_AUTO_SCALE | VERT_INTERP_BILINEAR |
> 		    HORIZ_INTERP_BILINEAR;
>@@ -758,6 +764,9 @@ i830_lvds_mode_fixup(xf86OutputPtr output, DisplayModePtr mode,
> 		if (mode->HDisplay & 1) /* odd resolutions */
> 		    right_border++;
> 
>+		ErrorF("left border %d, right border %d\n", left_border,
>+		       right_border);
>+
> 		adjusted_mode->CrtcHDisplay = scaled_width;
> 		adjusted_mode->CrtcHBlankStart = scaled_width +
> 		    right_border - 1;
>@@ -765,11 +774,23 @@ i830_lvds_mode_fixup(xf86OutputPtr output, DisplayModePtr mode,
> 		    left_border - 1;
> 		adjusted_mode->CrtcHSyncStart = adjusted_mode->CrtcHBlankStart;
> 		adjusted_mode->CrtcHSyncEnd = adjusted_mode->CrtcHBlankEnd;
>+
>+		ErrorF("mapping %dx%d to %dx%d\n",
>+		       mode->HDisplay, mode->VDisplay,
>+		       adjusted_mode->HDisplay, adjusted_mode->VDisplay);
>+
>+		ErrorF("CRTC timings: %d %d %d %d %d\n",
>+		       adjusted_mode->CrtcHDisplay, adjusted_mode->CrtcHBlankStart,
>+		       adjusted_mode->CrtcHBlankEnd, adjusted_mode->CrtcHSyncStart,
>+		       adjusted_mode->CrtcHSyncEnd);
>+
> 		border = 1;
> 	    } else if (panel_ratio < desired_ratio) { /* Letter */
> 		unsigned long scaled_height = (float)mode->VDisplay *
> 		    horiz_scale;
> 
>+		ErrorF("letterbox scaling\n");
>+
> 		vert_ratio = horiz_ratio;
> 		pfit_control |= HORIZ_AUTO_SCALE | VERT_INTERP_BILINEAR |
> 		    HORIZ_INTERP_BILINEAR;
>@@ -801,6 +822,8 @@ i830_lvds_mode_fixup(xf86OutputPtr output, DisplayModePtr mode,
> 				PFIT_VERT_SCALE_MASK) |
> 			       ((horiz_bits << PFIT_HORIZ_SCALE_SHIFT) &
> 				PFIT_HORIZ_SCALE_MASK));
>+	    ErrorF("pfit ratios: vertical 0x%08x, horizontal 0x%08x\n",
>+		   vert_bits, horiz_bits);
> 	}
> 	break;
>     case FULL:

Actions: View | Splinter Review

Attachments on bug 20951: 24383 | 24384 | 24385 | 24430 | 24446 | 24482 | 24483 | 24487 | 24650 | 24753 | 24759 | 24774 | 24775 | 25589 | 25612 | 25616 | 25647 | 25648 | 25649 | 25650 | 25651 | 25652 | 25654 | 25677 | 25732 | 25768 | 25781 | 25820 | 25831 | 26552 | 26617 | 26632 | 26633 | 26635 | 26657 | 26689 | 26698 | 26739

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.