Attachment 25655 Details for Bug 20340 – Remove subpixel offset from viewport

[patch] Remove subpixel offset from viewport

0001-Remove-subpixel-offset-from-viewport.patch (text/plain), 1.93 KB, created by Owen Taylor on 2009-05-08 16:01:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Taylor

Created: 2009-05-08 16:01:17 UTC

Size: 1.93 KB

patch

obsolete

>From a5d0e7bf8e1e3e814832f13e72103a4fba531d4c Mon Sep 17 00:00:00 2001
>From: Owen W. Taylor <otaylor@fishsoup.net>
>Date: Fri, 8 May 2009 18:58:41 -0400
>Subject: [PATCH] Remove subpixel offset from viewport
>
>Remove an eigth-pixel offset of the viewport inherited from
>R100 code. This seems not to be necessary and causes blurring
>when sampling textures 1:1.
>
>https://bugs.freedesktop.org/show_bug.cgi?id=20340
>---
> src/mesa/drivers/dri/r300/r300_state.c |   14 ++++----------
> 1 files changed, 4 insertions(+), 10 deletions(-)
>
>diff --git a/src/mesa/drivers/dri/r300/r300_state.c b/src/mesa/drivers/dri/r300/r300_state.c
>index 5d4f821..1419596 100644
>--- a/src/mesa/drivers/dri/r300/r300_state.c
>+++ b/src/mesa/drivers/dri/r300/r300_state.c
>@@ -922,12 +922,6 @@ static void r300StencilOpSeparate(GLcontext * ctx, GLenum face,
>  * Window position and viewport transformation
>  */
> 
>-/*
>- * To correctly position primitives:
>- */
>-#define SUBPIXEL_X 0.125
>-#define SUBPIXEL_Y 0.125
>-
> static void r300UpdateWindow(GLcontext * ctx)
> {
> 	r300ContextPtr rmesa = R300_CONTEXT(ctx);
>@@ -948,9 +942,9 @@ static void r300UpdateWindow(GLcontext * ctx)
> 	}
> 
> 	GLfloat sx = v[MAT_SX];
>-	GLfloat tx = v[MAT_TX] + xoffset + SUBPIXEL_X;
>+	GLfloat tx = v[MAT_TX] + xoffset;
> 	GLfloat sy = v[MAT_SY] * y_scale;
>-	GLfloat ty = (v[MAT_TY] * y_scale) + y_bias + SUBPIXEL_Y;
>+	GLfloat ty = (v[MAT_TY] * y_scale) + y_bias;
> 	GLfloat sz = v[MAT_SZ] * depthScale;
> 	GLfloat tz = v[MAT_TZ] * depthScale;
> 
>@@ -989,8 +983,8 @@ void r300UpdateViewportOffset(GLcontext * ctx)
> 	GLfloat yoffset = (GLfloat) dPriv->y + dPriv->h;
> 	const GLfloat *v = ctx->Viewport._WindowMap.m;
> 
>-	GLfloat tx = v[MAT_TX] + xoffset + SUBPIXEL_X;
>-	GLfloat ty = (-v[MAT_TY]) + yoffset + SUBPIXEL_Y;
>+	GLfloat tx = v[MAT_TX] + xoffset;
>+	GLfloat ty = (-v[MAT_TY]) + yoffset;
> 
> 	if (rmesa->hw.vpt.cmd[R300_VPT_XOFFSET] != r300PackFloat32(tx) ||
> 	    rmesa->hw.vpt.cmd[R300_VPT_YOFFSET] != r300PackFloat32(ty)) {
>-- 
>1.6.2.2
>

Actions: View | Splinter Review

Attachments on bug 20340: 23344 | 23345 | 25653 | 25655 | 30043

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.