Attachment 26591 Details for Bug 18016 – PLL: RV620 PLL shutdowning fix

[patch] PLL: RV620 PLL shutdowning fix

0001-PLL-RV620-PLL-shutdowning-fix-sometimes-we-need-un.patch (text/plain), 1.53 KB, created by Rafał Miłecki on 2009-06-09 09:39:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Rafał Miłecki

Created: 2009-06-09 09:39:16 UTC

Size: 1.53 KB

patch

obsolete

>From 5fb995902e6758a80444e8abeb75d2e96c7c66f3 Mon Sep 17 00:00:00 2001
>From: =?utf-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <zajec5@gmail.com>
>Date: Tue, 9 Jun 2009 18:26:30 +0200
>Subject: [PATCH] PLL: RV620 PLL shutdowning fix (sometimes we need unused PLL running)
>
>This makes RV620PLLnPower follow AtomBIOS method, fixes bug #18016
>---
> src/rhd_pll.c |   12 ++++++++++--
> 1 files changed, 10 insertions(+), 2 deletions(-)
>
>diff --git a/src/rhd_pll.c b/src/rhd_pll.c
>index 45ab03a..c9efd9a 100644
>--- a/src/rhd_pll.c
>+++ b/src/rhd_pll.c
>@@ -732,9 +732,13 @@ RV620PLL1Power(struct rhdPLL *PLL, int Power)
> 	RHDRegMask(PLL, P1PLL_CNTL, 0x01, 0x01); /* Reset */
> 	usleep(2);
> 
>-	RHDRegMask(PLL, P1PLL_CNTL, 0x02, 0x02); /* Power down */
>+	/* Sometimes we have to keep unused PLL running, see bug #18016 */
>+	if ((RHDRegRead(PLL, RV620_EXT1_DIFF_POST_DIV_CNTL) & 0x0100) == 0)
>+	    RHDRegMask(PLL, P1PLL_CNTL, 0x02, 0x02); /* Power down */
> 	usleep(200);
> 
>+	RHDRegMask(PLL, P1PLL_CNTL, 0x2000, 0x2000); /* reset anti-glitch */
>+
> 	return;
>     }
> }
>@@ -781,9 +785,13 @@ RV620PLL2Power(struct rhdPLL *PLL, int Power)
> 	RHDRegMask(PLL, P2PLL_CNTL, 0x01, 0x01); /* Reset */
> 	usleep(2);
> 
>-	RHDRegMask(PLL, P2PLL_CNTL, 0x02, 0x02); /* Power down */
>+	/* Sometimes we have to keep unused PLL running, see bug #18016 */
>+	if ((RHDRegRead(PLL, RV620_EXT2_DIFF_POST_DIV_CNTL) & 0x0100) == 0)
>+	    RHDRegMask(PLL, P2PLL_CNTL, 0x02, 0x02); /* Power down */
> 	usleep(200);
> 
>+	RHDRegMask(PLL, P2PLL_CNTL, 0x2000, 0x2000); /* reset anti-glitch */
>+
> 	return;
>     }
> }
>-- 
>1.6.0.2
>

Actions: View | Splinter Review

Attachments on bug 18016: 19586 | 20006 | 20007 | 20008 | 20009 | 20321 | 20322 | 20323 | 20324 | 20325 | 20326 | 20497 | 25242 | 25243 | 25245 | 26164 | 26495 | 26591

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.